Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: runtime/vm/jit_optimizer.cc

Issue 2859673002: Pass type argument vector to generic functions (if --reify-generic-functions is (Closed)
Patch Set: sync and work in progress Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/jit_optimizer.cc
diff --git a/runtime/vm/jit_optimizer.cc b/runtime/vm/jit_optimizer.cc
index fb6ee1d43be1d01be334cbb573a14b2f57af868e..7ec7472f71050fb912335c3ce6417e3c481f72a5 100644
--- a/runtime/vm/jit_optimizer.cc
+++ b/runtime/vm/jit_optimizer.cc
@@ -137,10 +137,7 @@ bool JitOptimizer::TryCreateICData(InstanceCallInstr* call) {
// finalized yet.
return false;
}
- const Array& args_desc_array =
- Array::Handle(Z, ArgumentsDescriptor::New(call->ArgumentCount(),
- call->argument_names()));
- ArgumentsDescriptor args_desc(args_desc_array);
+ ArgumentsDescriptor args_desc(call->GetArgumentsDescriptor(Z));
bool allow_add = false;
const Function& function = Function::Handle(
Z, Resolver::ResolveDynamicForReceiverClass(
@@ -171,9 +168,11 @@ bool JitOptimizer::TryCreateICData(InstanceCallInstr* call) {
const Class& owner_class = Class::Handle(Z, function().Owner());
if (!owner_class.is_abstract() && !CHA::HasSubclasses(owner_class) &&
!CHA::IsImplemented(owner_class)) {
- const Array& args_desc_array =
- Array::Handle(Z, ArgumentsDescriptor::New(call->ArgumentCount(),
- call->argument_names()));
+ const int kTypeArgsLen = 0;
+ ASSERT(call->type_args_len() == kTypeArgsLen);
+ const Array& args_desc_array = Array::Handle(
+ Z, ArgumentsDescriptor::New(kTypeArgsLen, call->ArgumentCount(),
+ call->argument_names()));
ArgumentsDescriptor args_desc(args_desc_array);
bool allow_add = false;
const Function& function = Function::Handle(

Powered by Google App Engine
This is Rietveld 408576698