Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Unified Diff: runtime/vm/jit_optimizer.cc

Issue 2859673002: Pass type argument vector to generic functions (if --reify-generic-functions is (Closed)
Patch Set: address review comments and sync Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_x64.cc ('k') | runtime/vm/kernel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/jit_optimizer.cc
diff --git a/runtime/vm/jit_optimizer.cc b/runtime/vm/jit_optimizer.cc
index ef43a489f9eefe59b65373c525e9766d91bf4e7e..d536fd60223a8b8b5a4cc5f375fccb5f35733de2 100644
--- a/runtime/vm/jit_optimizer.cc
+++ b/runtime/vm/jit_optimizer.cc
@@ -137,10 +137,8 @@ bool JitOptimizer::TryCreateICData(InstanceCallInstr* call) {
// finalized yet.
return false;
}
- const Array& args_desc_array =
- Array::Handle(Z, ArgumentsDescriptor::New(call->ArgumentCount(),
- call->argument_names()));
- ArgumentsDescriptor args_desc(args_desc_array);
+ ArgumentsDescriptor args_desc(
+ Array::Handle(Z, call->GetArgumentsDescriptor()));
bool allow_add = false;
const Function& function = Function::Handle(
Z, Resolver::ResolveDynamicForReceiverClass(
@@ -171,9 +169,11 @@ bool JitOptimizer::TryCreateICData(InstanceCallInstr* call) {
const Class& owner_class = Class::Handle(Z, function().Owner());
if (!owner_class.is_abstract() && !CHA::HasSubclasses(owner_class) &&
!CHA::IsImplemented(owner_class)) {
- const Array& args_desc_array =
- Array::Handle(Z, ArgumentsDescriptor::New(call->ArgumentCount(),
- call->argument_names()));
+ const int kTypeArgsLen = 0;
+ ASSERT(call->type_args_len() == kTypeArgsLen);
+ const Array& args_desc_array = Array::Handle(
+ Z, ArgumentsDescriptor::New(kTypeArgsLen, call->ArgumentCount(),
+ call->argument_names()));
ArgumentsDescriptor args_desc(args_desc_array);
bool allow_add = false;
const Function& function = Function::Handle(
« no previous file with comments | « runtime/vm/intermediate_language_x64.cc ('k') | runtime/vm/kernel.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698