Pass type argument vector to generic functions (if --reify-generic-functions is

runtime/lib/function.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bootstrap_natives.h"
 
 #include "vm/compiler.h"
 #include "vm/dart_entry.h"
 #include "vm/exceptions.h"
 #include "vm/native_entry.h"
 #include "vm/object.h"
 #include "vm/symbols.h"
 
 namespace dart {
 
 DEFINE_NATIVE_ENTRY(Function_apply, 2) {
+  const int kTypeArgsLen = 0;  // TODO(regis): Add support for generic function.
   const Array& fun_arguments = Array::CheckedHandle(arguments->NativeArgAt(0));
   const Array& fun_arg_names = Array::CheckedHandle(arguments->NativeArgAt(1));
-  const Array& fun_args_desc = Array::Handle(
-      ArgumentsDescriptor::New(fun_arguments.Length(), fun_arg_names));
+  const Array& fun_args_desc = Array::Handle(ArgumentsDescriptor::New(
+      kTypeArgsLen, fun_arguments.Length(), fun_arg_names));
   const Object& result =
       Object::Handle(DartEntry::InvokeClosure(fun_arguments, fun_args_desc));
   if (result.IsError()) {
     Exceptions::PropagateError(Error::Cast(result));
   }
   return result.raw();
 }
 
 
 DEFINE_NATIVE_ENTRY(Closure_equals, 2) {
   const Closure& receiver =
       Closure::CheckedHandle(zone, arguments->NativeArgAt(0));

[zra, 2017/05/03 15:03:24]

The stuff in this file is inconsistent about passing the zone when we allocate
handles.  It looks like there is always a zone passed in to DEFINE_NATIVE_ENTRY
functions.

[regis, 2017/05/09 18:31:22]

It looks like 'zone' is indeed passed in and is a stack zone. I added 'zone'
where it was missing.

   GET_NATIVE_ARGUMENT(Instance, other, arguments->NativeArgAt(1));
   ASSERT(!other.IsNull());
   if (receiver.raw() == other.raw()) return Bool::True().raw();
   if (other.IsClosure()) {
     const Function& func_a = Function::Handle(receiver.function());
     const Function& func_b = Function::Handle(Closure::Cast(other).function());
     if (func_a.raw() == func_b.raw()) {
       ASSERT(!func_a.IsImplicitStaticClosureFunction());
       if (func_a.IsImplicitInstanceClosureFunction()) {
         const Context& context_a = Context::Handle(receiver.context());
@@ skipping 46 matching lines @@
   for (int i = 0; i < context.num_variables(); i++) {
     instance = context.At(i);
     cloned_context.SetAt(i, instance);
   }
   return Closure::New(instantiator_type_arguments, function_type_arguments,
                       function, cloned_context);
 }
 
 
 }  // namespace dart