Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

Issue 2859623002: DevTools: Migrate from -webkit-user-modify to contenteditable (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @implements {UI.ContextFlavorListener} 5 * @implements {UI.ContextFlavorListener}
6 * @implements {UI.ToolbarItem.ItemsProvider} 6 * @implements {UI.ToolbarItem.ItemsProvider}
7 * @unrestricted 7 * @unrestricted
8 */ 8 */
9 Sources.XHRBreakpointsSidebarPane = class extends Components.BreakpointsSidebarP aneBase { 9 Sources.XHRBreakpointsSidebarPane = class extends Components.BreakpointsSidebarP aneBase {
10 constructor() { 10 constructor() {
(...skipping 23 matching lines...) Expand all
34 contextMenu.show(); 34 contextMenu.show();
35 } 35 }
36 36
37 _addButtonClicked() { 37 _addButtonClicked() {
38 UI.viewManager.showView('sources.xhrBreakpoints'); 38 UI.viewManager.showView('sources.xhrBreakpoints');
39 39
40 var inputElementContainer = createElementWithClass('p', 'breakpoint-conditio n'); 40 var inputElementContainer = createElementWithClass('p', 'breakpoint-conditio n');
41 inputElementContainer.textContent = Common.UIString('Break when URL contains :'); 41 inputElementContainer.textContent = Common.UIString('Break when URL contains :');
42 42
43 var inputElement = inputElementContainer.createChild('span', 'editing'); 43 var inputElement = inputElementContainer.createChild('span', 'editing');
44 inputElement.setAttribute('contenteditable', 'plaintext-only');
44 inputElement.id = 'breakpoint-condition-input'; 45 inputElement.id = 'breakpoint-condition-input';
45 this.addListElement(inputElementContainer, /** @type {?Element} */ (this.lis tElement.firstChild)); 46 this.addListElement(inputElementContainer, /** @type {?Element} */ (this.lis tElement.firstChild));
46 47
47 /** 48 /**
48 * @param {boolean} accept 49 * @param {boolean} accept
49 * @param {!Element} e 50 * @param {!Element} e
50 * @param {string} text 51 * @param {string} text
51 * @this {Sources.XHRBreakpointsSidebarPane} 52 * @this {Sources.XHRBreakpointsSidebarPane}
52 */ 53 */
53 function finishEditing(accept, e, text) { 54 function finishEditing(accept, e, text) {
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 contextMenu.show(); 136 contextMenu.show();
136 } 137 }
137 138
138 _checkboxClicked(url, event) { 139 _checkboxClicked(url, event) {
139 SDK.domDebuggerManager.toggleXHRBreakpoint(url, event.target.checked); 140 SDK.domDebuggerManager.toggleXHRBreakpoint(url, event.target.checked);
140 } 141 }
141 142
142 _labelClicked(url) { 143 _labelClicked(url) {
143 var element = this._breakpointElements.get(url) || null; 144 var element = this._breakpointElements.get(url) || null;
144 var inputElement = createElementWithClass('span', 'breakpoint-condition edit ing'); 145 var inputElement = createElementWithClass('span', 'breakpoint-condition edit ing');
146 inputElement.setAttribute('contenteditable', 'plaintext-only');
145 inputElement.textContent = url; 147 inputElement.textContent = url;
146 this.listElement.insertBefore(inputElement, element); 148 this.listElement.insertBefore(inputElement, element);
147 element.classList.add('hidden'); 149 element.classList.add('hidden');
148 150
149 /** 151 /**
150 * @param {boolean} accept 152 * @param {boolean} accept
151 * @param {!Element} e 153 * @param {!Element} e
152 * @param {string} text 154 * @param {string} text
153 * @this {Sources.XHRBreakpointsSidebarPane} 155 * @this {Sources.XHRBreakpointsSidebarPane}
154 */ 156 */
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 element.classList.add('breakpoint-hit'); 196 element.classList.add('breakpoint-hit');
195 this._highlightedElement = element; 197 this._highlightedElement = element;
196 } 198 }
197 199
198 _restoreBreakpoints() { 200 _restoreBreakpoints() {
199 var breakpoints = SDK.domDebuggerManager.xhrBreakpoints(); 201 var breakpoints = SDK.domDebuggerManager.xhrBreakpoints();
200 for (var url of breakpoints.keys()) 202 for (var url of breakpoints.keys())
201 this._setBreakpoint(url, breakpoints.get(url)); 203 this._setBreakpoint(url, breakpoints.get(url));
202 } 204 }
203 }; 205 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698