Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 2859553003: Update PlatformSensorAmbientLightMac constructor (Closed)

Created:
3 years, 7 months ago by juncai
Modified:
3 years, 7 months ago
CC:
chromium-reviews, mac-reviews_chromium.org, wanming.lin, shalamov, Mikhail
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update PlatformSensorAmbientLightMac constructor This CL removes the |type| parameter from PlatformSensorAmbientLightMac constructor and updates the comments. BUG=None

Patch Set 1 : update PlatformSensorAmbientLightMac constructor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M device/generic_sensor/platform_sensor_ambient_light_mac.h View 1 chunk +3 lines, -5 lines 0 comments Download
M device/generic_sensor/platform_sensor_ambient_light_mac.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M device/generic_sensor/platform_sensor_provider_mac.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
juncai
Please take a look.
3 years, 7 months ago (2017-05-03 02:00:02 UTC) #6
Reilly Grant (use Gerrit)
lgtm
3 years, 7 months ago (2017-05-03 02:02:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859553003/1
3 years, 7 months ago (2017-05-03 02:56:52 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 03:03:51 UTC) #12
Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

Powered by Google App Engine
This is Rietveld 408576698