chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrTestBase.java - Issue 2859533003: WebVR: lock focus while presenting to presenting window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrTestBase.java

Issue 2859533003: WebVR: lock focus while presenting to presenting window (Closed)

Patch Set: Update comment + fix comment line lengths Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrTestBase.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrTestBase.java b/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrTestBase.java

index d0bc08084143402e9b66f1f3ff95a3d957fc5ca4..b3715723c26431af6438a8d5c2dcb7c2a5080231 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrTestBase.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrTestBase.java

@@ -193,7 +193,7 @@ public class VrTestBase extends ChromeTabbedActivityTestBase {

* @param webContents The WebContents for the tab the JavaScript step is in

protected void waitOnJavaScriptStep(WebContents webContents) {

- assertTrue("Polling JavaScript boolean javascriptDone succeeded",

+ assertTrue("Polling JavaScript boolean javascriptDone timed out",

pollJavaScriptBoolean("javascriptDone", POLL_TIMEOUT_LONG_MS, webContents));

// Reset the synchronization boolean

runJavaScriptOrFail("javascriptDone = false", POLL_TIMEOUT_SHORT_MS, webContents);

« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java » ('j') | no next file with comments »