extensions/utility/unpacker_unittest.cc - Issue 2859513002: Fix potential buffer over-read errors for un-terminated JSON strings and comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/utility/unpacker_unittest.cc

Issue 2859513002: Fix potential buffer over-read errors for un-terminated JSON strings and comments. (Closed)

Patch Set: Address comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/utility/unpacker_unittest.cc

diff --git a/extensions/utility/unpacker_unittest.cc b/extensions/utility/unpacker_unittest.cc

index 3f9a53c3d7f0ac675fd76fc333cd27cf74d20c2f..1e31a680926a05badab57f0dd1aa40e0253bd0de 100644

--- a/extensions/utility/unpacker_unittest.cc

+++ b/extensions/utility/unpacker_unittest.cc

@@ -89,9 +89,8 @@ TEST_F(UnpackerTest, InvalidMessagesFile) {

EXPECT_FALSE(unpacker_->Run());

EXPECT_TRUE(base::MatchPattern(

unpacker_->error_message(),

- ASCIIToUTF16(

- "*_locales?en_US?messages.json: Line: 2, column: 11,"

- " Syntax error.")))

+ ASCIIToUTF16("*_locales?en_US?messages.json: Line: 2, column: 10,"

+ " Syntax error.")))

<< unpacker_->error_message();

}