Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

Issue 2859483006: cc: Enable composited border-radius scrolling.
Patch Set: test expectation Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp b/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
index a476fa37e6c97f59091ea0023ad0cca20fca891c..938e2b62a6809ef664e49b4d25d3bc26bc81aa03 100644
--- a/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
+++ b/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
@@ -1134,11 +1134,6 @@ TEST_P(NonCompositedMainThreadScrollingReasonTest, BackgroundNotOpaqueTest) {
MainThreadScrollingReason::kBackgroundNotOpaqueInRectAndLCDText);
}
-TEST_P(NonCompositedMainThreadScrollingReasonTest, BorderRadiusTest) {
- TestNonCompositedReasons("border-radius",
- MainThreadScrollingReason::kHasBorderRadius);
-}
-
TEST_P(NonCompositedMainThreadScrollingReasonTest, ClipTest) {
TestNonCompositedReasons("clip",
MainThreadScrollingReason::kHasClipRelatedProperty);
@@ -1194,9 +1189,8 @@ TEST_P(NonCompositedMainThreadScrollingReasonTest, ClipPathTest) {
}
TEST_P(NonCompositedMainThreadScrollingReasonTest, LCDTextEnabledTest) {
- TestNonCompositedReasons("transparent border-radius",
- MainThreadScrollingReason::kHasOpacityAndLCDText |
- MainThreadScrollingReason::kHasBorderRadius);
+ TestNonCompositedReasons("transparent",
+ MainThreadScrollingReason::kHasOpacityAndLCDText);
}
TEST_P(NonCompositedMainThreadScrollingReasonTest, BoxShadowTest) {
@@ -1251,18 +1245,6 @@ TEST_P(NonCompositedMainThreadScrollingReasonTest,
ToLayoutBoxModelObject(container->GetLayoutObject())->GetScrollableArea();
ASSERT_TRUE(scrollable_area);
EXPECT_FALSE(scrollable_area->GetNonCompositedMainThreadScrollingReasons());
-
- Element* container2 = document->getElementById("scroller2");
chrishtr 2017/06/16 22:34:34 Please add a unittest here that it *does* composit
sunxd 2017/06/20 14:36:10 Done.
- ASSERT_TRUE(container2);
- container2->setAttribute("class", "composited border-radius",
- ASSERT_NO_EXCEPTION);
- ForceFullCompositingUpdate();
- PaintLayerScrollableArea* scrollable_area2 =
- ToLayoutBoxModelObject(container2->GetLayoutObject())
- ->GetScrollableArea();
- ASSERT_TRUE(scrollable_area2);
- EXPECT_TRUE(scrollable_area2->GetNonCompositedMainThreadScrollingReasons() &
- MainThreadScrollingReason::kHasBorderRadius);
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698