Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Issue 2859483006: cc: Enable composited border-radius scrolling.
Patch Set: Make respect-clip-for-non-composited-scrollers-when-prefering-compositing-to-lcd-text.html not a re… Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
index c438cf02eb89b27ee507e657c12a2d6998906d3c..6b4c3dd8b4220b30cf3152ee6372a0cefe0b4f4a 100644
--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
@@ -591,9 +591,6 @@ void CompositedLayerMapping::
if (!clipping_container)
return;
- if (clipping_container->EnclosingLayer() == scroll_parent)
- return;
-
if (compositing_ancestor->GetLayoutObject().IsDescendantOf(
clipping_container))
return;
@@ -624,6 +621,9 @@ void CompositedLayerMapping::
owning_layer_is_clipped &&
clipping_container->Style()->HasBorderRadius() &&
!AncestorRoundedCornersWontClip(GetLayoutObject(), *clipping_container);
+
+ if (clipping_container->EnclosingLayer() == scroll_parent)
+ owning_layer_is_clipped = owning_layer_is_masked;
trchen 2017/05/22 23:00:06 Could you document what does this line do? Actuall
sunxd 2017/06/15 15:59:10 Sure. It was added due to this bug: crbug.com/4507
Stephen Chennney 2017/06/15 17:44:24 Will we not now have the same problem as crbug.com
sunxd 2017/06/15 19:59:20 Oh sorry I think this change should be reverted as
}
const PaintLayer* CompositedLayerMapping::ScrollParent() {

Powered by Google App Engine
This is Rietveld 408576698