Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: chrome/browser/prerender/prerender_browsertest.cc

Issue 2859393002: Report page load timing information for child frames. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_browsertest.cc
diff --git a/chrome/browser/prerender/prerender_browsertest.cc b/chrome/browser/prerender/prerender_browsertest.cc
index 3fb3cf44336a173d24de353b9eeebf7f1ae89186..24a5fb9906911f0a0badb496e63030802d7821a7 100644
--- a/chrome/browser/prerender/prerender_browsertest.cc
+++ b/chrome/browser/prerender/prerender_browsertest.cc
@@ -3440,7 +3440,8 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, FirstContentfulPaintTimingSimple) {
base::TimeDelta::FromMilliseconds(2654);
page_load_metrics::PageLoadMetricsObserverTestHarness::
PopulateRequiredTimingFields(&timing);
- observer.OnFirstContentfulPaint(timing, GenericPageLoadExtraInfo(dest_url()));
+ observer.OnFirstContentfulPaintInPage(timing,
+ GenericPageLoadExtraInfo(dest_url()));
histogram_tester().ExpectTotalCount(
"Prerender.websame_PrefetchTTFCP.Warm.Cacheable.Visible", 1);
@@ -3481,7 +3482,8 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, FirstContentfulPaintTimingReuse) {
base::TimeDelta::FromMilliseconds(2361);
page_load_metrics::PageLoadMetricsObserverTestHarness::
PopulateRequiredTimingFields(&timing);
- observer.OnFirstContentfulPaint(timing, GenericPageLoadExtraInfo(dest_url()));
+ observer.OnFirstContentfulPaintInPage(timing,
+ GenericPageLoadExtraInfo(dest_url()));
histogram_tester().ExpectTotalCount(
"Prerender.websame_PrefetchTTFCP.Warm.Cacheable.Visible", 1);
@@ -3522,7 +3524,8 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
base::TimeDelta::FromMilliseconds(2361);
page_load_metrics::PageLoadMetricsObserverTestHarness::
PopulateRequiredTimingFields(&timing);
- observer.OnFirstContentfulPaint(timing, GenericPageLoadExtraInfo(dest_url()));
+ observer.OnFirstContentfulPaintInPage(timing,
+ GenericPageLoadExtraInfo(dest_url()));
histogram_tester().ExpectTotalCount(
"Prerender.websame_PrefetchTTFCP.Warm.Cacheable.Visible", 1);
@@ -3565,7 +3568,8 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
base::TimeDelta::FromMilliseconds(2362);
page_load_metrics::PageLoadMetricsObserverTestHarness::
PopulateRequiredTimingFields(&timing);
- observer.OnFirstContentfulPaint(timing, GenericPageLoadExtraInfo(dest_url()));
+ observer.OnFirstContentfulPaintInPage(timing,
+ GenericPageLoadExtraInfo(dest_url()));
histogram_tester().ExpectTotalCount(
"Prerender.none_PrefetchTTFCP.Warm.Cacheable.Visible", 0);
@@ -3615,7 +3619,8 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
base::TimeDelta::FromMilliseconds(2654);
page_load_metrics::PageLoadMetricsObserverTestHarness::
PopulateRequiredTimingFields(&timing);
- observer.OnFirstContentfulPaint(timing, GenericPageLoadExtraInfo(dest_url()));
+ observer.OnFirstContentfulPaintInPage(timing,
+ GenericPageLoadExtraInfo(dest_url()));
histogram_tester().ExpectTotalCount(
"Prerender.websame_PrefetchTTFCP.Warm.Cacheable.Visible", 1);
@@ -3646,7 +3651,8 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, FirstContentfulPaintHidden) {
base::TimeDelta::FromMilliseconds(2654);
page_load_metrics::PageLoadMetricsObserverTestHarness::
PopulateRequiredTimingFields(&timing);
- observer.OnFirstContentfulPaint(timing, GenericPageLoadExtraInfo(dest_url()));
+ observer.OnFirstContentfulPaintInPage(timing,
+ GenericPageLoadExtraInfo(dest_url()));
histogram_tester().ExpectTotalCount(
"Prerender.websame_PrefetchTTFCP.Warm.Cacheable.Hidden", 1);
@@ -3691,7 +3697,8 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
base::TimeDelta::FromMilliseconds(2362);
page_load_metrics::PageLoadMetricsObserverTestHarness::
PopulateRequiredTimingFields(&timing);
- observer.OnFirstContentfulPaint(timing, GenericPageLoadExtraInfo(dest_url()));
+ observer.OnFirstContentfulPaintInPage(timing,
+ GenericPageLoadExtraInfo(dest_url()));
histogram_tester().ExpectTotalCount(
"Prerender.none_PrefetchTTFCP.Warm.Cacheable.Hidden", 0);

Powered by Google App Engine
This is Rietveld 408576698