Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc

Issue 2859393002: Report page load timing information for child frames. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc
index eaa61a7ad4e2d7371ea8683acdaf7d58d3f1f43a..6afd3a58e09d3856f5a2c1c2a7621345966ac7be 100644
--- a/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc
@@ -67,9 +67,10 @@ ResourcePrefetchPredictorPageLoadMetricsObserver::OnHidden(
return CONTINUE_OBSERVING;
}
-void ResourcePrefetchPredictorPageLoadMetricsObserver::OnFirstContentfulPaint(
- const page_load_metrics::PageLoadTiming& timing,
- const page_load_metrics::PageLoadExtraInfo& extra_info) {
+void ResourcePrefetchPredictorPageLoadMetricsObserver::
+ OnFirstContentfulPaintInPage(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& extra_info) {
predictors::NavigationID navigation_id(web_contents_);
predictor_->RecordFirstContentfulPaint(
@@ -82,9 +83,10 @@ void ResourcePrefetchPredictorPageLoadMetricsObserver::OnFirstContentfulPaint(
}
}
-void ResourcePrefetchPredictorPageLoadMetricsObserver::OnFirstMeaningfulPaint(
- const page_load_metrics::PageLoadTiming& timing,
- const page_load_metrics::PageLoadExtraInfo& extra_info) {
+void ResourcePrefetchPredictorPageLoadMetricsObserver::
+ OnFirstMeaningfulPaintInMainFrameDocument(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& extra_info) {
if (record_histograms_) {
PAGE_LOAD_HISTOGRAM(
internal::kHistogramResourcePrefetchPredictorFirstMeaningfulPaint,

Powered by Google App Engine
This is Rietveld 408576698