Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.cc

Issue 2859393002: Report page load timing information for child frames. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.cc
index df91dc07d33567fbe95c717f87224b540d0fac05..66a311dd631dd70c7c6153c2584b26a5fd05ae99 100644
--- a/chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.cc
@@ -60,7 +60,7 @@ OmniboxSuggestionUsedMetricsObserver::OnCommit(
: STOP_OBSERVING;
}
-void OmniboxSuggestionUsedMetricsObserver::OnFirstContentfulPaint(
+void OmniboxSuggestionUsedMetricsObserver::OnFirstContentfulPaintInPage(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) {
base::TimeDelta fcp = timing.paint_timing.first_contentful_paint.value();
@@ -95,9 +95,10 @@ void OmniboxSuggestionUsedMetricsObserver::OnFirstContentfulPaint(
}
}
-void OmniboxSuggestionUsedMetricsObserver::OnFirstMeaningfulPaint(
- const page_load_metrics::PageLoadTiming& timing,
- const page_load_metrics::PageLoadExtraInfo& info) {
+void OmniboxSuggestionUsedMetricsObserver::
+ OnFirstMeaningfulPaintInMainFrameDocument(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info) {
base::TimeDelta fmp = timing.paint_timing.first_meaningful_paint.value();
if (info.started_in_foreground) {

Powered by Google App Engine
This is Rietveld 408576698