Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1652)

Unified Diff: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc

Issue 2859393002: Report page load timing information for child frames. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
index d1fbb2f7aa3a3358b6942aab0701a8308a8fac4e..0d70e1a83f08d63ec9d9ac4aa3a05d2e4e7c0479 100644
--- a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
@@ -354,7 +354,7 @@ void DataReductionProxyMetricsObserver::OnFirstLayout(
internal::kHistogramFirstLayoutSuffix);
}
-void DataReductionProxyMetricsObserver::OnFirstPaint(
+void DataReductionProxyMetricsObserver::OnFirstPaintInPage(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) {
RECORD_FOREGROUND_HISTOGRAMS_FOR_SUFFIX(info, data_,
@@ -362,7 +362,7 @@ void DataReductionProxyMetricsObserver::OnFirstPaint(
internal::kHistogramFirstPaintSuffix);
}
-void DataReductionProxyMetricsObserver::OnFirstTextPaint(
+void DataReductionProxyMetricsObserver::OnFirstTextPaintInPage(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) {
RECORD_FOREGROUND_HISTOGRAMS_FOR_SUFFIX(
@@ -370,7 +370,7 @@ void DataReductionProxyMetricsObserver::OnFirstTextPaint(
internal::kHistogramFirstTextPaintSuffix);
}
-void DataReductionProxyMetricsObserver::OnFirstImagePaint(
+void DataReductionProxyMetricsObserver::OnFirstImagePaintInPage(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) {
RECORD_FOREGROUND_HISTOGRAMS_FOR_SUFFIX(
@@ -378,7 +378,7 @@ void DataReductionProxyMetricsObserver::OnFirstImagePaint(
internal::kHistogramFirstImagePaintSuffix);
}
-void DataReductionProxyMetricsObserver::OnFirstContentfulPaint(
+void DataReductionProxyMetricsObserver::OnFirstContentfulPaintInPage(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) {
RECORD_FOREGROUND_HISTOGRAMS_FOR_SUFFIX(
@@ -386,9 +386,10 @@ void DataReductionProxyMetricsObserver::OnFirstContentfulPaint(
internal::kHistogramFirstContentfulPaintSuffix);
}
-void DataReductionProxyMetricsObserver::OnFirstMeaningfulPaint(
- const page_load_metrics::PageLoadTiming& timing,
- const page_load_metrics::PageLoadExtraInfo& info) {
+void DataReductionProxyMetricsObserver::
+ OnFirstMeaningfulPaintInMainFrameDocument(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info) {
RECORD_FOREGROUND_HISTOGRAMS_FOR_SUFFIX(
info, data_, timing.paint_timing.first_meaningful_paint,
internal::kHistogramFirstMeaningfulPaintSuffix);

Powered by Google App Engine
This is Rietveld 408576698