chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc - Issue 2859393002: Report page load timing information for child frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc

Issue 2859393002: Report page load timing information for child frames. (Closed)

Patch Set: add comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.h ('k') | chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.h » ('j') | chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc

index 92564c97820e5917100fe0fd11b2304f6a64fc61..8da822e5d395257d0741261f3a831bd0c54da1fe 100644

--- a/chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc

@@ -43,7 +43,7 @@ NoStatePrefetchPageLoadMetricsObserver::OnCommit(

return CONTINUE_OBSERVING;

}

-void NoStatePrefetchPageLoadMetricsObserver::OnFirstContentfulPaint(

+void NoStatePrefetchPageLoadMetricsObserver::OnFirstContentfulPaintInPage(

const page_load_metrics::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& extra_info) {

DCHECK(timing.paint_timing.first_contentful_paint.has_value());