Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

Issue 2859393002: Report page load timing information for child frames. (Closed)
Patch Set: add comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc » ('j') | chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
index da5467859faa298854b8db4bb1cd779c9c974837..ccae5a73afe4c22f7c53b9cc34d70b64e3be9b86 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
@@ -103,19 +103,19 @@ class CorePageLoadMetricsObserver
void OnFirstLayout(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) override;
- void OnFirstPaint(
+ void OnFirstPaintInPage(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) override;
- void OnFirstTextPaint(
+ void OnFirstTextPaintInPage(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) override;
- void OnFirstImagePaint(
+ void OnFirstImagePaintInPage(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) override;
- void OnFirstContentfulPaint(
+ void OnFirstContentfulPaintInPage(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) override;
- void OnFirstMeaningfulPaint(
+ void OnFirstMeaningfulPaintInMainFrameDocument(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) override;
void OnParseStart(
« no previous file with comments | « chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc » ('j') | chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698