Index: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc |
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc |
index 1b52ea8f37126e974d13ff08f527fb609c81d5e5..0fff39fa53b1772aacd15f4a75fbc6fa3cbef2b8 100644 |
--- a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc |
+++ b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc |
@@ -30,6 +30,7 @@ |
#include "content/public/browser/render_view_host.h" |
#include "content/public/test/browser_test_utils.h" |
#include "content/public/test/download_test_observer.h" |
+#include "net/dns/mock_host_resolver.h" |
#include "net/http/failing_http_transaction_factory.h" |
#include "net/http/http_cache.h" |
#include "net/test/embedded_test_server/embedded_test_server.h" |
@@ -125,6 +126,12 @@ class PageLoadMetricsBrowserTest : public InProcessBrowserTest { |
ui_test_utils::NavigateToURL(browser(), GURL(url::kAboutBlankURL)); |
} |
+ void SetUpOnMainThread() override { |
+ host_resolver()->AddRule("a.com", "127.0.0.1"); |
+ host_resolver()->AddRule("b.com", "127.0.0.1"); |
+ content::SetupCrossSiteRedirector(embedded_test_server()); |
+ } |
+ |
bool NoPageLoadMetricsRecorded() { |
// Determine whether any 'public' page load metrics are recorded. We exclude |
// 'internal' metrics as these may be recorded for debugging purposes. |
@@ -176,6 +183,7 @@ IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, NewPage) { |
histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 1); |
histogram_tester_.ExpectTotalCount(internal::kHistogramLoad, 1); |
histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 1); |
+ histogram_tester_.ExpectTotalCount(internal::kHistogramFirstPaint, 1); |
histogram_tester_.ExpectTotalCount(internal::kHistogramParseDuration, 1); |
histogram_tester_.ExpectTotalCount( |
internal::kHistogramParseBlockedOnScriptLoad, 1); |
@@ -190,6 +198,42 @@ IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, NewPage) { |
EXPECT_FALSE(NoPageLoadMetricsRecorded()); |
} |
+IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, NoPaintForEmptyDocument) { |
+ ASSERT_TRUE(embedded_test_server()->Start()); |
+ |
+ ui_test_utils::NavigateToURL(browser(), |
+ embedded_test_server()->GetURL("/empty.html")); |
+ NavigateToUntrackedUrl(); |
+ |
+ histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 1); |
+ histogram_tester_.ExpectTotalCount(internal::kHistogramFirstPaint, 0); |
+} |
+ |
+IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, |
+ NoPaintForEmptyDocumentInFrame) { |
+ ASSERT_TRUE(embedded_test_server()->Start()); |
+ |
+ GURL a_url(embedded_test_server()->GetURL( |
+ "a.com", "/page_load_metrics/empty_iframe.html")); |
+ ui_test_utils::NavigateToURL(browser(), a_url); |
+ NavigateToUntrackedUrl(); |
+ |
+ histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 1); |
+ histogram_tester_.ExpectTotalCount(internal::kHistogramFirstPaint, 0); |
+} |
+ |
+IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, PaintInChildFrame) { |
+ ASSERT_TRUE(embedded_test_server()->Start()); |
+ |
+ GURL a_url(embedded_test_server()->GetURL("a.com", |
+ "/page_load_metrics/iframe.html")); |
+ ui_test_utils::NavigateToURL(browser(), a_url); |
+ NavigateToUntrackedUrl(); |
+ |
+ histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 1); |
+ histogram_tester_.ExpectTotalCount(internal::kHistogramFirstPaint, 1); |
+} |
+ |
IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, SameDocumentNavigation) { |
ASSERT_TRUE(embedded_test_server()->Start()); |