Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3890)

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

Issue 2859393002: Report page load timing information for child frames. (Closed)
Patch Set: add browsertests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
index 044495e8c15477c6feb9d26f3b8e58b564fdebe0..01e59277ac22c31d7af4f52d03b9c5a760d0ca4b 100644
--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
@@ -596,11 +596,7 @@ void MetricsWebContentsObserver::OnTimingUpdated(
return;
if (render_frame_host->GetParent() != nullptr) {
- // Child frames may send PageLoadMetadata updates, but not PageLoadTiming
- // updates.
- if (!timing.IsEmpty())
- RecordInternalError(ERR_TIMING_IPC_FROM_SUBFRAME);
- committed_load_->UpdateChildFrameMetadata(metadata);
+ committed_load_->UpdateSubFrameTiming(render_frame_host, timing, metadata);
return;
}

Powered by Google App Engine
This is Rietveld 408576698