Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Side by Side Diff: chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc

Issue 2859393002: Report page load timing information for child frames. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/page_load_metrics/observers/previews_page_load_metrics_ observer.h" 5 #include "chrome/browser/page_load_metrics/observers/previews_page_load_metrics_ observer.h"
6 6
7 #include "base/optional.h" 7 #include "base/optional.h"
8 #include "base/time/time.h" 8 #include "base/time/time.h"
9 #include "chrome/browser/page_load_metrics/page_load_metrics_util.h" 9 #include "chrome/browser/page_load_metrics/page_load_metrics_util.h"
10 #include "chrome/common/page_load_metrics/page_load_timing.h" 10 #include "chrome/common/page_load_metrics/page_load_timing.h"
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 const page_load_metrics::PageLoadTiming& timing, 87 const page_load_metrics::PageLoadTiming& timing,
88 const page_load_metrics::PageLoadExtraInfo& info) { 88 const page_load_metrics::PageLoadExtraInfo& info) {
89 if (!WasStartedInForegroundOptionalEventInForeground( 89 if (!WasStartedInForegroundOptionalEventInForeground(
90 timing.document_timing.first_layout, info)) { 90 timing.document_timing.first_layout, info)) {
91 return; 91 return;
92 } 92 }
93 PAGE_LOAD_HISTOGRAM(internal::kHistogramOfflinePreviewsFirstLayout, 93 PAGE_LOAD_HISTOGRAM(internal::kHistogramOfflinePreviewsFirstLayout,
94 timing.document_timing.first_layout.value()); 94 timing.document_timing.first_layout.value());
95 } 95 }
96 96
97 void PreviewsPageLoadMetricsObserver::OnFirstContentfulPaint( 97 void PreviewsPageLoadMetricsObserver::OnFirstContentfulPaintInPage(
98 const page_load_metrics::PageLoadTiming& timing, 98 const page_load_metrics::PageLoadTiming& timing,
99 const page_load_metrics::PageLoadExtraInfo& info) { 99 const page_load_metrics::PageLoadExtraInfo& info) {
100 if (!WasStartedInForegroundOptionalEventInForeground( 100 if (!WasStartedInForegroundOptionalEventInForeground(
101 timing.paint_timing.first_contentful_paint, info)) { 101 timing.paint_timing.first_contentful_paint, info)) {
102 return; 102 return;
103 } 103 }
104 PAGE_LOAD_HISTOGRAM(internal::kHistogramOfflinePreviewsFirstContentfulPaint, 104 PAGE_LOAD_HISTOGRAM(internal::kHistogramOfflinePreviewsFirstContentfulPaint,
105 timing.paint_timing.first_contentful_paint.value()); 105 timing.paint_timing.first_contentful_paint.value());
106 } 106 }
107 107
(...skipping 13 matching lines...) Expand all
121 #if defined(OS_ANDROID) 121 #if defined(OS_ANDROID)
122 offline_pages::OfflinePageTabHelper* tab_helper = 122 offline_pages::OfflinePageTabHelper* tab_helper =
123 offline_pages::OfflinePageTabHelper::FromWebContents(web_contents); 123 offline_pages::OfflinePageTabHelper::FromWebContents(web_contents);
124 return tab_helper && tab_helper->IsShowingOfflinePreview(); 124 return tab_helper && tab_helper->IsShowingOfflinePreview();
125 #else 125 #else
126 return false; 126 return false;
127 #endif // defined(OS_ANDROID) 127 #endif // defined(OS_ANDROID)
128 } 128 }
129 129
130 } // namespace previews 130 } // namespace previews
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698