Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc

Issue 2859393002: Report page load timing information for child frames. (Closed)
Patch Set: add comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/page_load_metrics/page_timing_metrics_sender.h" 5 #include "chrome/renderer/page_load_metrics/page_timing_metrics_sender.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
(...skipping 12 matching lines...) Expand all
23 IPC::Sender* ipc_sender, 23 IPC::Sender* ipc_sender,
24 int routing_id, 24 int routing_id,
25 std::unique_ptr<base::Timer> timer, 25 std::unique_ptr<base::Timer> timer,
26 const PageLoadTiming& initial_timing) 26 const PageLoadTiming& initial_timing)
27 : ipc_sender_(ipc_sender), 27 : ipc_sender_(ipc_sender),
28 routing_id_(routing_id), 28 routing_id_(routing_id),
29 timer_(std::move(timer)), 29 timer_(std::move(timer)),
30 last_timing_(initial_timing), 30 last_timing_(initial_timing),
31 metadata_(PageLoadMetadata()) { 31 metadata_(PageLoadMetadata()) {
32 if (!initial_timing.IsEmpty()) { 32 if (!initial_timing.IsEmpty()) {
33 // Send an initial IPC relatively early to help track aborts. 33 EnsureSendTimer();
34 EnsureSendTimer(kInitialTimerDelayMillis);
35 } 34 }
36 } 35 }
37 36
38 // On destruction, we want to send any data we have if we have a timer 37 // On destruction, we want to send any data we have if we have a timer
39 // currently running (and thus are talking to a browser process) 38 // currently running (and thus are talking to a browser process)
40 PageTimingMetricsSender::~PageTimingMetricsSender() { 39 PageTimingMetricsSender::~PageTimingMetricsSender() {
41 if (timer_->IsRunning()) { 40 if (timer_->IsRunning()) {
42 timer_->Stop(); 41 timer_->Stop();
43 SendNow(); 42 SendNow();
44 } 43 }
45 } 44 }
46 45
47 void PageTimingMetricsSender::DidObserveLoadingBehavior( 46 void PageTimingMetricsSender::DidObserveLoadingBehavior(
48 blink::WebLoadingBehaviorFlag behavior) { 47 blink::WebLoadingBehaviorFlag behavior) {
49 if (behavior & metadata_.behavior_flags) 48 if (behavior & metadata_.behavior_flags)
50 return; 49 return;
51 metadata_.behavior_flags |= behavior; 50 metadata_.behavior_flags |= behavior;
52 EnsureSendTimer(kTimerDelayMillis); 51 EnsureSendTimer();
53 } 52 }
54 53
55 void PageTimingMetricsSender::Send(const PageLoadTiming& timing) { 54 void PageTimingMetricsSender::Send(const PageLoadTiming& timing) {
56 if (timing == last_timing_) 55 if (timing == last_timing_)
57 return; 56 return;
58 57
59 // We want to make sure that each PageTimingMetricsSender is associated 58 // We want to make sure that each PageTimingMetricsSender is associated
60 // with a distinct page navigation. Because we reset the object on commit, 59 // with a distinct page navigation. Because we reset the object on commit,
61 // we can trash last_timing_ on a provisional load before SendNow() fires. 60 // we can trash last_timing_ on a provisional load before SendNow() fires.
62 if (!last_timing_.navigation_start.is_null() && 61 if (!last_timing_.navigation_start.is_null() &&
63 last_timing_.navigation_start != timing.navigation_start) { 62 last_timing_.navigation_start != timing.navigation_start) {
64 return; 63 return;
65 } 64 }
66 65
67 last_timing_ = timing; 66 last_timing_ = timing;
68 EnsureSendTimer(kTimerDelayMillis); 67 EnsureSendTimer();
69 } 68 }
70 69
71 void PageTimingMetricsSender::EnsureSendTimer(int delay) { 70 void PageTimingMetricsSender::EnsureSendTimer() {
72 if (!timer_->IsRunning()) 71 if (!timer_->IsRunning()) {
72 // Send the first IPC eagerly to make sure the receiving side knows we're
73 // sending metrics as soon as possible.
74 int delay_ms =
75 have_sent_ipc_ ? kTimerDelayMillis : kInitialTimerDelayMillis;
73 timer_->Start( 76 timer_->Start(
74 FROM_HERE, base::TimeDelta::FromMilliseconds(delay), 77 FROM_HERE, base::TimeDelta::FromMilliseconds(delay_ms),
75 base::Bind(&PageTimingMetricsSender::SendNow, base::Unretained(this))); 78 base::Bind(&PageTimingMetricsSender::SendNow, base::Unretained(this)));
79 }
76 } 80 }
77 81
78 void PageTimingMetricsSender::SendNow() { 82 void PageTimingMetricsSender::SendNow() {
83 have_sent_ipc_ = true;
79 ipc_sender_->Send(new PageLoadMetricsMsg_TimingUpdated( 84 ipc_sender_->Send(new PageLoadMetricsMsg_TimingUpdated(
80 routing_id_, last_timing_, metadata_)); 85 routing_id_, last_timing_, metadata_));
81 } 86 }
82 87
83 } // namespace page_load_metrics 88 } // namespace page_load_metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698