Report page load timing information for child frames.

chrome/browser/page_load_metrics/page_load_metrics_observer.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_PAGE_LOAD_METRICS_OBSERVER_H_
 #define CHROME_BROWSER_PAGE_LOAD_METRICS_PAGE_LOAD_METRICS_OBSERVER_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 252 matching lines @@
   // callbacks to indicate whether the observer would like to continue observing
   // metric callbacks. Observers that wish to continue observing metric
   // callbacks should return CONTINUE_OBSERVING; observers that wish to stop
   // observing callbacks should return STOP_OBSERVING. Observers that return
   // STOP_OBSERVING may be deleted.
   enum ObservePolicy {
     CONTINUE_OBSERVING,
     STOP_OBSERVING,
   };
 
+  using FrameTreeNodeId = int;
+
   virtual ~PageLoadMetricsObserver() {}
 
   // The page load started, with the given navigation handle.
   // currently_committed_url contains the URL of the committed page load at the
   // time the navigation for navigation_handle was initiated, or the empty URL
   // if there was no committed page load at the time the navigation was
   // initiated.
   virtual ObservePolicy OnStart(content::NavigationHandle* navigation_handle,
                                 const GURL& currently_committed_url,
                                 bool started_in_foreground);
@@ skipping 45 matching lines @@
   // callbacks below.
 
   // OnTimingUpdate is triggered when an updated PageLoadTiming is
   // available. This method may be called multiple times over the course of the
   // page load. This method is currently only intended for use in testing. Most
   // implementers should implement one of the On* callbacks, such as
   // OnFirstContentfulPaint or OnDomContentLoadedEventStart. Please email
   // loading-dev@chromium.org if you intend to override this method.
   virtual void OnTimingUpdate(const PageLoadTiming& timing,
                               const PageLoadExtraInfo& extra_info) {}
+
+  // OnSubFrameTimingUpdate is triggered when an updated PageLoadTiming or
+  // PageLoadMetadata is available for a child frame of the current page
+  // load. The FrameTreeNodeId identifies the frame that
+  // |navigation_start_offset|, |child_timing|, and |child_metadata| are
+  // associated with. |extra_info| contains the extra info associated with the
+  // page. |navigation_start_offset| reports the offset of the subframe's
+  // navigation start from the main frame's navigation_start. The timings
+  // reported in |child_timing| are relative to the subframe's navigation start.
+  virtual void OnSubFrameTimingUpdate(FrameTreeNodeId child_frame_id,

[jkarlin, 2017/05/10 16:55:28]

I'd rather we not create this until a client that needs it (other than tests)
comes along.

[Bryan McQuade, 2017/05/10 18:06:15]

sure - i think i can switch over to using the TestingObserver::OnTimingUpdated
callback once we land the other change.

+                                      base::TimeDelta navigation_start_offset,
+                                      const PageLoadTiming& child_timing,
+                                      const PageLoadMetadata& child_metadata,
+                                      const PageLoadExtraInfo& extra_info) {}
+
   // OnUserInput is triggered when a new user input is passed in to
   // web_contents. Contains a TimeDelta from navigation start.
   virtual void OnUserInput(const blink::WebInputEvent& event) {}
 
   // The following methods are invoked at most once, when the timing for the
   // associated event first becomes available.
   virtual void OnDomContentLoadedEventStart(
       const PageLoadTiming& timing,
       const PageLoadExtraInfo& extra_info) {}
   virtual void OnLoadEventStart(const PageLoadTiming& timing,
                                 const PageLoadExtraInfo& extra_info) {}
   virtual void OnFirstLayout(const PageLoadTiming& timing,
                              const PageLoadExtraInfo& extra_info) {}
-  virtual void OnFirstPaint(const PageLoadTiming& timing,
-                            const PageLoadExtraInfo& extra_info) {}
-  virtual void OnFirstTextPaint(const PageLoadTiming& timing,
-                                const PageLoadExtraInfo& extra_info) {}
-  virtual void OnFirstImagePaint(const PageLoadTiming& timing,
-                                 const PageLoadExtraInfo& extra_info) {}
-  virtual void OnFirstContentfulPaint(const PageLoadTiming& timing,
-                                      const PageLoadExtraInfo& extra_info) {}
-  virtual void OnFirstMeaningfulPaint(const PageLoadTiming& timing,
-                                      const PageLoadExtraInfo& extra_info) {}
   virtual void OnParseStart(const PageLoadTiming& timing,
                             const PageLoadExtraInfo& extra_info) {}
   virtual void OnParseStop(const PageLoadTiming& timing,
                            const PageLoadExtraInfo& extra_info) {}
 
+  // On*PaintInPage(...) are invoked when the first relevant paint in the page,
+  // across all frames, is observed.
+  virtual void OnFirstPaintInPage(const PageLoadTiming& timing,
+                                  const PageLoadExtraInfo& extra_info) {}
+  virtual void OnFirstTextPaintInPage(const PageLoadTiming& timing,
+                                      const PageLoadExtraInfo& extra_info) {}
+  virtual void OnFirstImagePaintInPage(const PageLoadTiming& timing,
+                                       const PageLoadExtraInfo& extra_info) {}
+  virtual void OnFirstContentfulPaintInPage(
+      const PageLoadTiming& timing,
+      const PageLoadExtraInfo& extra_info) {}
+
+  // Unlike other paint callbacks, OnFirstMeaningfulPaintInMainFrameDocument is
+  // tracked per document, and is reported for the main frame document only.
+  virtual void OnFirstMeaningfulPaintInMainFrameDocument(
+      const PageLoadTiming& timing,
+      const PageLoadExtraInfo& extra_info) {}
+
   // Invoked when there is a change in either the main_frame_metadata or the
   // child_frame_metadata's loading behavior_flags.
   virtual void OnLoadingBehaviorObserved(
       const page_load_metrics::PageLoadExtraInfo& extra_info) {}
 
   // Invoked when a media element starts playing.
   virtual void MediaStartedPlaying(
       const content::WebContentsObserver::MediaPlayerInfo& video_type,
       bool is_in_main_frame) {}
 
@@ skipping 50 matching lines @@
   // Called whenever a request is loaded for this page load. This comes
   // unfiltered from the ResourceDispatcherHost and may include blob requests
   // and data uris.
   virtual void OnLoadedResource(
       const ExtraRequestCompleteInfo& extra_request_complete_info) {}
 };
 
 }  // namespace page_load_metrics
 
 #endif  // CHROME_BROWSER_PAGE_LOAD_METRICS_PAGE_LOAD_METRICS_OBSERVER_H_