 Chromium Code Reviews
 Chromium Code Reviews Issue 2859363003:
  cros: Initial structure for views-based lock.  (Closed)
    
  
    Issue 2859363003:
  cros: Initial structure for views-based lock.  (Closed) 
  | OLD | NEW | 
|---|---|
| (Empty) | |
| 1 // Copyright 2017 The Chromium Authors. All rights reserved. | |
| 2 // Use of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 #ifndef ASH_LOGIN_VIEWS_CONTENTS_VIEW_H_ | |
| 6 #define ASH_LOGIN_VIEWS_CONTENTS_VIEW_H_ | |
| 7 | |
| 8 #include "base/macros.h" | |
| 9 #include "ui/views/controls/button/md_text_button.h" | |
| 10 #include "ui/views/view.h" | |
| 11 | |
| 12 namespace ash { | |
| 13 | |
| 14 // ContentsView hosts the root view for the lock screen. | |
| 
James Cook
2017/05/08 22:04:20
Is there a single instance, or one per display?
 
jdufault
2017/05/08 23:02:34
Done.
 | |
| 15 class ContentsView : public views::View, public views::ButtonListener { | |
| 
James Cook
2017/05/08 22:04:20
I would prefer unique class names for as long as w
 
jdufault
2017/05/08 23:02:34
Done.
 | |
| 16 public: | |
| 17 ContentsView(); | |
| 18 ~ContentsView() override; | |
| 19 | |
| 20 // views::ButtonListener | |
| 
James Cook
2017/05/08 22:04:20
super nit: end with :
 
jdufault
2017/05/08 23:02:34
Done.
 | |
| 21 void ButtonPressed(views::Button* sender, const ui::Event& event) override; | |
| 22 | |
| 23 private: | |
| 24 views::Button* unlock_button_; | |
| 25 | |
| 26 DISALLOW_COPY_AND_ASSIGN(ContentsView); | |
| 27 }; | |
| 28 | |
| 29 } // ash | |
| 
James Cook
2017/05/08 22:04:20
"namespace ash"
 
jdufault
2017/05/08 23:02:34
Done.
 | |
| 30 | |
| 31 #endif // ASH_LOGIN_VIEWS_CONTENTS_VIEW_H_ | |
| OLD | NEW |