Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2859343003: Enable overriding interface binders for any services running in current process. (Closed)
Patch Set: Address nit Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 15283cb405f4729ad809960ddc183ff5da2961cf..d3db7468dbf619e9cc67bcbfbe4e80b9632b6b95 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -3852,20 +3852,23 @@ void RenderFrameHostImpl::BeforeUnloadTimeout() {
class RenderFrameHostImpl::JavaInterfaceProvider
: public service_manager::mojom::InterfaceProvider {
public:
+ using BindCallback =
+ base::Callback<void(const std::string&, mojo::ScopedMessagePipeHandle)>;
+
JavaInterfaceProvider(
- const service_manager::BinderRegistry::Binder& bind_callback,
+ const BindCallback& bind_callback,
service_manager::mojom::InterfaceProviderRequest request)
: bind_callback_(bind_callback), binding_(this, std::move(request)) {}
~JavaInterfaceProvider() override = default;
private:
- // service_manager::mojom::INterfaceProvider:
+ // service_manager::mojom::InterfaceProvider:
void GetInterface(const std::string& interface_name,
mojo::ScopedMessagePipeHandle handle) override {
bind_callback_.Run(interface_name, std::move(handle));
}
- service_manager::BinderRegistry::Binder bind_callback_;
+ const BindCallback bind_callback_;
mojo::Binding<service_manager::mojom::InterfaceProvider> binding_;
DISALLOW_COPY_AND_ASSIGN(JavaInterfaceProvider);
« no previous file with comments | « no previous file | content/browser/vibration_browsertest.cc » ('j') | services/service_manager/public/cpp/service_context.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698