cros: Fix bubble dialog shows on desktop when parent window is invisible

ui/views/widget/native_widget_aura_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/native_widget_aura.h"
 
 #include <memory>
 
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "services/ui/public/interfaces/window_manager_constants.mojom.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/env.h"
 #include "ui/aura/layout_manager.h"
 #include "ui/aura/test/aura_test_base.h"
 #include "ui/aura/window.h"
 #include "ui/aura/window_observer.h"
 #include "ui/aura/window_tree_host.h"
 #include "ui/events/event.h"
 #include "ui/events/event_utils.h"
 #include "ui/views/layout/fill_layout.h"
 #include "ui/views/test/widget_test.h"
 #include "ui/views/widget/root_view.h"
 #include "ui/views/widget/widget_delegate.h"
 #include "ui/wm/core/base_focus_rules.h"
 #include "ui/wm/core/default_activation_client.h"
 #include "ui/wm/core/focus_controller.h"
+#include "ui/wm/core/transient_window_manager.h"
 
 namespace views {
 namespace {
 
 NativeWidgetAura* Init(aura::Window* parent, Widget* widget) {
   Widget::InitParams params(Widget::InitParams::TYPE_POPUP);
   params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
   params.parent = parent;
   widget->Init(params);
   return static_cast<NativeWidgetAura*>(widget->native_widget());
@@ skipping 604 matching lines @@
   views::test::TestInitialFocusWidgetDelegate delegate(root_window());
   delegate.GetWidget()->Show();
   EXPECT_FALSE(delegate.view()->HasFocus());
 
   test_focus_rules()->set_can_activate(true);
   views::test::TestInitialFocusWidgetDelegate delegate2(root_window());
   delegate2.GetWidget()->Show();
   EXPECT_TRUE(delegate2.view()->HasFocus());
 }
 
+// Tests that the transient child bubble window is only visible if the parent is
+// visible.
+TEST_F(NativeWidgetAuraTest, VisibilityOfChildBubbleWindow) {
+  // Create a parent window.
+  std::unique_ptr<Widget> parent(new Widget);

[sky, 2017/05/08 22:42:11]

No need for the unique_ptr here, declare parent on the stack.

[Qiang(Joe) Xu, 2017/05/08 22:55:57]

Done.

+  Widget::InitParams parent_params(Widget::InitParams::TYPE_WINDOW);
+  parent_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
+  parent_params.context = root_window();
+  parent->Init(parent_params);
+  parent->SetBounds(gfx::Rect(0, 0, 480, 320));
+
+  // Add a child bubble window to the above parent window and show it.
+  std::unique_ptr<Widget> child(new Widget);

[sky, 2017/05/08 22:42:11]

Same comment here.

[Qiang(Joe) Xu, 2017/05/08 22:55:57]

Done.

+  Widget::InitParams child_params(Widget::InitParams::TYPE_BUBBLE);
+  child_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
+  child_params.parent = parent->GetNativeWindow();
+  child->Init(child_params);
+  child->SetBounds(gfx::Rect(0, 0, 200, 200));
+  child->Show();
+
+  // Check that the bubble window is added as the transient child and it is
+  // hidden because parent window is hidden.
+  wm::TransientWindowManager* manager =
+      wm::TransientWindowManager::Get(child->GetNativeWindow());
+  EXPECT_EQ(parent->GetNativeWindow(), manager->transient_parent());
+  EXPECT_FALSE(parent->IsVisible());
+  EXPECT_FALSE(child->IsVisible());
+
+  // Show the parent window should make the transient child bubble visible.
+  parent->Show();
+  EXPECT_TRUE(parent->IsVisible());
+  EXPECT_TRUE(child->IsVisible());
+}
+
 }  // namespace
 }  // namespace views