third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.h - Issue 2859313003: Blink class layout optimization to reduce memory usage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.h

Issue 2859313003: Blink class layout optimization to reduce memory usage (Closed)

Patch Set: Resolved merge conflict and changed blink::ResourceStatus enum to be based on uint8_t Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.h

diff --git a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.h b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.h

index 9a842c3acf208c4a2c1e5be45fa4e81bfe1486c6..73eafe8a1b0ddf726c6e12971a7371f2d0a9a968 100644

--- a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.h

+++ b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.h

@@ -98,16 +98,16 @@ class PLATFORM_EXPORT DeferredImageDecoder final {

// Copy of the data that is passed in, used by deferred decoding.

// Allows creating readonly snapshots that may be read in another thread.

std::unique_ptr<SkRWBuffer> rw_buffer_;

- bool all_data_received_;

std::unique_ptr<ImageDecoder> actual_decoder_;

String filename_extension_;

IntSize size_;

int repetition_count_;

bool has_embedded_color_space_ = false;

- sk_sp<SkColorSpace> color_space_for_sk_images_;

+ bool all_data_received_;

bool can_yuv_decode_;

bool has_hot_spot_;

+ sk_sp<SkColorSpace> color_space_for_sk_images_;

IntPoint hot_spot_;

// Caches frame state information.