third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h - Issue 2859293002: Use union instead of overload fo DOMMatrix/DOMMatrixReadOnly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h

Issue 2859293002: Use union instead of overload fo DOMMatrix/DOMMatrixReadOnly (Closed)

Patch Set: x Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h

diff --git a/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h b/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h

index 7fa2944bb5ff63fafc28a380b8c42732903c4ea0..10ae70a0e5f1903f4e0e0261f0ab12e1cac95a3b 100644

--- a/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h

+++ b/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h

@@ -7,6 +7,7 @@

#include <memory>

#include "bindings/core/v8/ExceptionState.h"

+#include "bindings/core/v8/StringOrUnrestrictedDoubleSequence.h"

#include "core/dom/ArrayBufferViewHelpers.h"

#include "core/dom/DOMTypedArray.h"

#include "platform/bindings/ScriptWrappable.h"

@@ -27,8 +28,8 @@ class CORE_EXPORT DOMMatrixReadOnly

public:

static DOMMatrixReadOnly* Create(ExceptionState&);

- static DOMMatrixReadOnly* Create(const String&, ExceptionState&);

- static DOMMatrixReadOnly* Create(Vector<double>, ExceptionState&);

+ static DOMMatrixReadOnly* Create(StringOrUnrestrictedDoubleSequence&,

+ ExceptionState&);

static DOMMatrixReadOnly* fromFloat32Array(NotShared<DOMFloat32Array>,

ExceptionState&);

static DOMMatrixReadOnly* fromFloat64Array(NotShared<DOMFloat64Array>,