Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: components/password_manager/core/browser/password_manager_metrics_util.h

Issue 2859243004: Add metrics for PasswordForm submission types (Closed)
Patch Set: addressed reviewer comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_metrics_util.h
diff --git a/components/password_manager/core/browser/password_manager_metrics_util.h b/components/password_manager/core/browser/password_manager_metrics_util.h
index 2fb1b73140487a3564f351cdef36bbca338046a6..20ba9cfcb4d85b6c431532e2d79864a7f4358bd0 100644
--- a/components/password_manager/core/browser/password_manager_metrics_util.h
+++ b/components/password_manager/core/browser/password_manager_metrics_util.h
@@ -9,6 +9,8 @@
#include <string>
+#include "components/autofill/core/common/password_form.h"
+
namespace password_manager {
namespace metrics_util {
@@ -264,6 +266,10 @@ void LogShowedHttpNotSecureExplanation();
// per main-frame navigation.
void LogShowedFormNotSecureWarningOnCurrentNavigation();
+// Log a password successful submission event.
+void LogPasswordSuccessfulSubmissionIndicatorEvent(
+ autofill::PasswordForm::SubmissionIndicatorEvent event);
+
} // namespace metrics_util
} // namespace password_manager

Powered by Google App Engine
This is Rietveld 408576698