Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2016)

Unified Diff: components/autofill/content/common/autofill_types.mojom

Issue 2859243004: Add metrics for PasswordForm submission types (Closed)
Patch Set: addressed reviewer comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/common/autofill_types.mojom
diff --git a/components/autofill/content/common/autofill_types.mojom b/components/autofill/content/common/autofill_types.mojom
index 5e0c6ee9f3a6b6286d7ec98b32ae3598e3483762..bb3be97f230d099ecc09b18be2d10b15e0700e4e 100644
--- a/components/autofill/content/common/autofill_types.mojom
+++ b/components/autofill/content/common/autofill_types.mojom
@@ -52,6 +52,17 @@ enum PasswordFormScheme {
SCHEME_USERNAME_ONLY
};
+// autofill::PasswordForm::SubmissionIndicatorEvent
+enum PasswordFormSubmissionIndicatorEvent {
+ NONE,
+ HTML_FORM_SUBMISSION,
+ SAME_DOCUMENT_NAVIGATION,
+ XHR_SUCCEEDED,
+ FRAME_DETACHED,
+ MANUAL_SAVE,
+ SUBMISSION_INDICATOR_EVENT_COUNT
+};
+
// autofill::PasswordFormFieldPredictionType
enum PasswordFormFieldPredictionType {
PREDICTION_USERNAME,
@@ -182,6 +193,7 @@ struct PasswordForm {
bool is_public_suffix_match;
bool is_affiliation_based_match;
bool does_look_like_signup_form;
+ PasswordFormSubmissionIndicatorEvent submission_event;
};
// TODO(leonhsl): Use map directly after http://crbug.com/628104 solved.

Powered by Google App Engine
This is Rietveld 408576698