Add metrics for PasswordForm submission types

components/autofill/core/common/password_form.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__
 #define COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__
 
 #include <map>
 #include <memory>
 #include <string>
@@ skipping 66 matching lines @@
   enum class Layout {
     // Forms which either do not need to be classified, or cannot be classified
     // meaningfully.
     LAYOUT_OTHER,
     // Login and signup forms combined in one <form>, to distinguish them from,
     // e.g., change-password forms.
     LAYOUT_LOGIN_AND_SIGNUP,
     LAYOUT_LAST = LAYOUT_LOGIN_AND_SIGNUP
   };
 
+  // Events that Password Manager uses as triggers for checking a success of a

[engedy, 2017/05/10 13:07:43]

Phrasing nit:

// Events observed by the Password Manager that indicate either that a form is
potentially being submitted, or that a form has already been successfully
submitted. Recorded into a UMA histogram, so order of enumerators should not be
changed. 

[dvadym, 2017/05/10 14:09:26]

Thanks, done

+  // password form submission.
+  enum class SubmissionIndicatorEvent {
+    NONE,
+    HTML_FORM_SUBMISSION,
+    INPAGE_NAVIGATION,

[engedy, 2017/05/10 13:07:42]

nit: SAME_DOCUMENT_NAVIGATION for consistency

[dvadym, 2017/05/10 14:09:26]

Done.

+    XHR_SUCCEEDED,
+    FRAME_DETACHED,
+    BY_CONTEXT_MENU_CLICK,

[engedy, 2017/05/10 13:07:43]

nit: This sounds like an implementation detail. Have you considered naming this
MANUAL_SAVE_OVERRIDE?

[dvadym, 2017/05/10 14:09:26]

Done.

+    SUBMISSION_EVENT_COUNT

[engedy, 2017/05/10 13:07:42]

nit: SUBMISSION_INDICATOR_EVENT_COUNT

[dvadym, 2017/05/10 14:09:26]

Done.

+  };
+
   // The "Realm" for the sign-on. This is scheme, host, port for SCHEME_HTML.
   // Dialog based forms also contain the HTTP realm. Android based forms will
   // contain a string of the form "android://<hash of cert>@<package name>"
   //
   // The signon_realm is effectively the primary key used for retrieving
   // data from the database, so it must not be empty.
   std::string signon_realm;
 
   // An origin URL consists of the scheme, host, port and path; the rest is
   // stripped. This is the primary data used by the PasswordManager to decide
@@ skipping 174 matching lines @@
   // If true, this match was found using public suffix matching.
   bool is_public_suffix_match;
 
   // If true, this is a credential saved through an Android application, and
   // found using affiliation-based match.
   bool is_affiliation_based_match;
 
   // If true, this form looks like SignUp form according to local heuristics.
   bool does_look_like_signup_form;
 
+  // Type of event which was used for this form submission.

[engedy, 2017/05/10 13:07:42]

Phrasing nit: 

// The type of the event that was taken as an indication that this form is being
or has already been submitted. This field is not persisted and filled out only
for submitted forms.

[dvadym, 2017/05/10 14:09:26]

Thanks, done

+  SubmissionIndicatorEvent submission_event;
+
   // Return true if we consider this form to be a change password form.
   // We use only client heuristics, so it could include signup forms.
   bool IsPossibleChangePasswordForm() const;
 
   // Return true if we consider this form to be a change password form
   // without username field. We use only client heuristics, so it could
   // include signup forms.
   bool IsPossibleChangePasswordFormWithoutUsername() const;
 
   // Equality operators for testing.
@@ skipping 17 matching lines @@
 };
 
 // Converts a vector of possible usernames to string.
 base::string16 OtherPossibleUsernamesToString(
     const PossibleUsernamesVector& possible_usernames);
 
 // For testing.
 std::ostream& operator<<(std::ostream& os, PasswordForm::Layout layout);
 std::ostream& operator<<(std::ostream& os, const PasswordForm& form);
 std::ostream& operator<<(std::ostream& os, PasswordForm* form);
+std::ostream& operator<<(
+    std::ostream& os,
+    PasswordForm::SubmissionIndicatorEvent submission_event);
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__