[Extensions] Improve app custom bindings

chrome/renderer/resources/extensions/app_custom_bindings.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Custom binding for the app API.
 
 var appNatives = requireNative('app');
 var process = requireNative('process');
 var extensionId = process.GetExtensionId();
 var logActivity = requireNative('activityLogger');
@@ skipping 17 matching lines @@
   getDetails: wrapForLogging(appNatives.GetDetails),
   runningState: wrapForLogging(appNatives.GetRunningState)
 };
 
 // Tricky; "getIsInstalled" is actually exposed as the getter "isInstalled",
 // but we don't have a way to express this in the schema JSON (nor is it
 // worth it for this one special case).
 //
 // So, define it manually, and let the getIsInstalled function act as its
 // documentation.
-app.__defineGetter__('isInstalled', wrapForLogging(appNatives.GetIsInstalled));
+var isInstalled = wrapForLogging(appNatives.GetIsInstalled);
+$Object.defineProperty(
+    app, 'isInstalled',
+    {
+      __proto__: null,
+      configurable: true,
+      enumerable: true,
+      get: function() { return isInstalled(); },
+    });
 
 // Called by app_bindings.cc.
 function onInstallStateResponse(state, callbackId) {
   var callback = callbacks[callbackId];
   delete callbacks[callbackId];
-  if (typeof(callback) == 'function') {
+  if (typeof callback == 'function') {
     try {
       callback(state);
     } catch (e) {
       console.error('Exception in chrome.app.installState response handler: ' +
                     e.stack);
     }
   }
 }
 
 // TODO(kalman): move this stuff to its own custom bindings.
-var callbacks = {};
+var callbacks = { __proto__: null };
 var nextCallbackId = 1;
 
-app.installState = function getInstallState(callback) {
+function getInstallState(callback) {
   var callbackId = nextCallbackId++;
   callbacks[callbackId] = callback;
   appNatives.GetInstallState(callbackId);
-};
-if (extensionId)
-  app.installState = wrapForLogging(app.installState);
+}
+
+var installState = wrapForLogging(getInstallState);
+$Object.defineProperty(
+    app, 'installState',
+    {
+      __proto__: null,
+      configurable: true,
+      enumerable: true,
+      get: function() { return installState; },

[jbroman, 2017/05/08 14:25:25]

This makes it an accessor property as opposed to a data property. Intentional?
I'd have expected:

$Object.defineProperty(
    app, 'installState',
    {
      __proto__: null,
      configurable: true,
      enumerable: true,
      // possibly also "writable: true" if you want to mimic the kind of
property app.installState ordinarily creates
      value: installState
    });

(Doesn't apply above, because you are replacing an accessor property there.)

[Devlin, 2017/05/11 14:30:38]

Done.

+    });
 
 exports.$set('binding', app);
 exports.$set('onInstallStateResponse', onInstallStateResponse);