chrome/android/junit/src/org/chromium/chrome/browser/notifications/channels/ChannelDefinitionsTest.java - Issue 2859233002: [Android] Refactor our notification channel definitions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/notifications/channels/ChannelDefinitionsTest.java

Issue 2859233002: [Android] Refactor our notification channel definitions (Closed)

Patch Set: Nits, and made ChannelsUpdaterTest more powerful again by mocking resources Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/notifications/channels/ChannelsInitializerTest.java ('k') | chrome/android/junit/src/org/chromium/chrome/browser/notifications/channels/ChannelsInitializerTest.java » ('j') | chrome/android/junit/src/org/chromium/chrome/browser/notifications/channels/ChannelsUpdaterTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/junit/src/org/chromium/chrome/browser/notifications/channels/ChannelDefinitionsTest.java

diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/notifications/channels/ChannelDefinitionsTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/notifications/channels/ChannelDefinitionsTest.java

index ff933a08f4eaa007dc638d95cc14f0f7d898d544..2c386aa43b7a02eb52dd01dbe4396230bc3658c9 100644

--- a/chrome/android/junit/src/org/chromium/chrome/browser/notifications/channels/ChannelDefinitionsTest.java

+++ b/chrome/android/junit/src/org/chromium/chrome/browser/notifications/channels/ChannelDefinitionsTest.java

@@ -20,8 +20,7 @@ import org.junit.runners.BlockJUnit4ClassRunner;

public class ChannelDefinitionsTest {

@Test

public void testNoOverlapBetweenStartupAndLegacyChannelIds() throws Exception {

- ChannelDefinitions channelDefinitions = new ChannelDefinitions();

- assertThat(channelDefinitions.getStartupChannelIds(),

- everyItem(not(isIn(channelDefinitions.getLegacyChannelIds()))));

+ assertThat(ChannelDefinitions.getStartupChannelIds(),

+ everyItem(not(isIn(ChannelDefinitions.getLegacyChannelIds()))));

}