chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderFactory.java - Issue 2859233002: [Android] Refactor our notification channel definitions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderFactory.java

Issue 2859233002: [Android] Refactor our notification channel definitions (Closed)

Patch Set: Nits, and made ChannelsUpdaterTest more powerful again by mocking resources Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxy.java » ('j') | chrome/android/junit/src/org/chromium/chrome/browser/notifications/channels/ChannelsUpdaterTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderFactory.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderFactory.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderFactory.java

index c6794917139ec92aa14cd87a33476c3ff659c8d6..9bcc2dc64c1e4b1ab321aaa5a3d6e9eb0ab495da 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderFactory.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderFactory.java

@@ -48,6 +48,6 @@ public class NotificationBuilderFactory {

return new NotificationBuilderForO(context, channelId,

new ChannelsInitializer(new NotificationManagerProxyImpl(context.getSystemService(

NotificationManager.class)),

- new ChannelDefinitions()));

+ context.getResources()));

}