src/bootstrapper.cc - Issue 2859203002: [string] Move String.p.toLowerCase to CSA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/bootstrapper.cc

Issue 2859203002: [string] Move String.p.toLowerCase to CSA (Closed)

Patch Set: Remove unused code Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/bootstrapper.cc

diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc

index 46e889f5a2c0be3acba18e6934252a860e74385e..a1d720797cb7b4fe34a4edbdfd3b5db21b7565f5 100644

--- a/src/bootstrapper.cc

+++ b/src/bootstrapper.cc

@@ -4084,7 +4084,7 @@ void Genesis::InitializeGlobal_icu_case_mapping() {

SetFunction(string_prototype,

SimpleCreateFunction(isolate(), name,

Builtins::kStringPrototypeToLowerCaseIntl,

- 0, false),

+ 0, true),

Camillo Bruni 2017/05/05 10:10:03 We should probably avoid the explicit arguments ad

jgruber 2017/05/05 10:21:58 sgtm. I got failures related to stack ptr / except

name);

}

{