Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6316)

Unified Diff: chrome/browser/ui/views/payments/payment_request_item_list.cc

Issue 2859193004: Remove GridLayout::SetInsets in favor of an empty border on the host. (Closed)
Patch Set: edits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/payment_request_item_list.cc
diff --git a/chrome/browser/ui/views/payments/payment_request_item_list.cc b/chrome/browser/ui/views/payments/payment_request_item_list.cc
index cef163242e9fdfa808184dc5bbd4a3782cd40a5f..ef16365b149a37b1f35a9fb3780beb758c080168 100644
--- a/chrome/browser/ui/views/payments/payment_request_item_list.cc
+++ b/chrome/browser/ui/views/payments/payment_request_item_list.cc
@@ -9,6 +9,7 @@
#include "chrome/browser/ui/views/payments/payment_request_views_util.h"
#include "components/payments/content/payment_request_state.h"
#include "ui/gfx/paint_vector_icon.h"
+#include "ui/views/border.h"
#include "ui/views/controls/image_view.h"
#include "ui/views/layout/box_layout.h"
#include "ui/views/layout/grid_layout.h"
@@ -78,10 +79,10 @@ std::unique_ptr<views::View> PaymentRequestItemList::Item::CreateItemView() {
views::GridLayout* layout = new views::GridLayout(row.get());
row->SetLayoutManager(layout);
- layout->SetInsets(
+ row->SetBorder(views::CreateEmptyBorder(
kPaymentRequestRowVerticalInsets, kPaymentRequestRowHorizontalInsets,
kPaymentRequestRowVerticalInsets,
- kPaymentRequestRowHorizontalInsets + kPaymentRequestRowExtraRightInset);
+ kPaymentRequestRowHorizontalInsets + kPaymentRequestRowExtraRightInset));
// Add a column for the item's content view.
views::ColumnSet* columns = layout->AddColumnSet(0);

Powered by Google App Engine
This is Rietveld 408576698