chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc - Issue 2859193004: Remove GridLayout::SetInsets in favor of an empty border on the host.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc

Issue 2859193004: Remove GridLayout::SetInsets in favor of an empty border on the host. (Closed)

Patch Set: fix compile and tests Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/payments/payment_request_views_util.h ('K') | « chrome/browser/ui/views/profiles/profile_chooser_view.cc ('k') | mash/catalog_viewer/catalog_viewer.cc » ('j') | ui/message_center/views/message_center_view_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc

diff --git a/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc b/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc

index 703f547950359a297c401bb4d5b36016c5029065..4315eba621e7401166b7259694ab53a03398c787 100644

--- a/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc

+++ b/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc

@@ -202,8 +202,9 @@ void ProfileSigninConfirmationDialogViews::ViewHierarchyChanged(

views::LayoutProvider::Get()->GetInsetsMetric(views::INSETS_PANEL);

// The prompt bar needs to go to the edge of the dialog, so ignore insets for

// the outer layout.

+ SetBorder(views::CreateEmptyBorder(panel_insets.top(), 0,

+ panel_insets.bottom(), 0));

views::GridLayout* dialog_layout = new views::GridLayout(this);

- dialog_layout->SetInsets(panel_insets.top(), 0, panel_insets.bottom(), 0);

SetLayoutManager(dialog_layout);

// Use GridLayout inside the prompt bar because StyledLabel requires it.