Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2859133003: Find native classes with mixins in NativeClassFinder (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Find native classes with mixins in NativeClassFinder We were skipping for instance NativeTypedArrayOfDouble because it mixes in ListMixin and FixedLengthListMixin. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/b7225cf5334b3aeabac4ce07b0a20b4b3beecfe6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -20 lines) Patch
M pkg/compiler/lib/src/common_elements.dart View 1 chunk +7 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map.dart View 3 chunks +23 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/native/resolver.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_strategy.dart View 1 chunk +9 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world2_test.dart View 2 chunks +22 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 7 months ago (2017-05-04 14:30:20 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 7 months ago (2017-05-04 19:19:11 UTC) #3
Johnni Winther
3 years, 7 months ago (2017-05-05 08:27:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b7225cf5334b3aeabac4ce07b0a20b4b3beecfe6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698