Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: chromeos/network/onc/onc_validator_unittest.cc

Issue 2859123003: Don't reject server and CA certs during device ONC validation (Closed)
Patch Set: Addressed comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/onc/onc_validator_unittest.cc
diff --git a/chromeos/network/onc/onc_validator_unittest.cc b/chromeos/network/onc/onc_validator_unittest.cc
index 917dffa2bc7b537623a4dbf7a8d7e487c4577871..e6f1d7c7f63cb2d9407b0aeb086cb8864496899b 100644
--- a/chromeos/network/onc/onc_validator_unittest.cc
+++ b/chromeos/network/onc/onc_validator_unittest.cc
@@ -163,6 +163,9 @@ INSTANTIATE_TEST_CASE_P(
OncParams("managed_toplevel_l2tpipsec.onc",
&kToplevelConfigurationSignature,
true),
+ OncParams("managed_toplevel_with_server_and_ca_cert.onc",
+ &kToplevelConfigurationSignature,
+ true),
OncParams("toplevel_wifi_hexssid.onc",
&kToplevelConfigurationSignature,
false),
@@ -462,14 +465,7 @@ INSTANTIATE_TEST_CASE_P(
&kNetworkConfigurationSignature,
false),
ExpectBothNotValid("wifi-ssid-and-hexssid-repaired",
- "wifi-ssid-and-hexssid-repaired")),
- std::make_pair(
- OncParams("toplevel-with-server-and-ca-cert",
- &kToplevelConfigurationSignature,
- true,
- ::onc::ONC_SOURCE_DEVICE_POLICY),
- ExpectBothNotValid("toplevel-server-and-ca-cert-dropped",
- "toplevel-server-and-ca-cert-dropped"))));
+ "wifi-ssid-and-hexssid-repaired"))));
// Strict and liberal validator both repair, but with different results.
INSTANTIATE_TEST_CASE_P(
« no previous file with comments | « chromeos/network/onc/onc_validator.cc ('k') | chromeos/test/data/network/invalid_settings_with_repairs.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698