Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js

Issue 2859063003: [Devtools] Restructure network nodes for friendlier products/grouping (Closed)
Patch Set: [Devtools] Restructure network nodes for friendlier products/grouping Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 } 156 }
157 157
158 /** 158 /**
159 * @return {!Protocol.Page.FrameId} 159 * @return {!Protocol.Page.FrameId}
160 */ 160 */
161 get frameId() { 161 get frameId() {
162 return this._frameId; 162 return this._frameId;
163 } 163 }
164 164
165 /** 165 /**
166 * @return {?SDK.ResourceTreeFrame}
167 */
168 resourceTreeFrame() {
pfeldman 2017/05/04 22:54:08 I would not depend on RTM here, the dependency goe
allada 2017/05/05 00:43:13 Done. It makes the code really ugly if I inline it
169 var resourceTreeModel = this._networkManager.target().model(SDK.ResourceTree Model);
170 if (!resourceTreeModel)
171 return null;
172 return resourceTreeModel.frameForId(this._frameId);
173 }
174
175 /**
166 * @return {!Protocol.Network.LoaderId} 176 * @return {!Protocol.Network.LoaderId}
167 */ 177 */
168 get loaderId() { 178 get loaderId() {
169 return this._loaderId; 179 return this._loaderId;
170 } 180 }
171 181
172 /** 182 /**
173 * @param {string} ip 183 * @param {string} ip
174 * @param {number} port 184 * @param {number} port
175 */ 185 */
(...skipping 972 matching lines...) Expand 10 before | Expand all | Expand 10 after
1148 Send: 'send', 1158 Send: 'send',
1149 Receive: 'receive', 1159 Receive: 'receive',
1150 Error: 'error' 1160 Error: 'error'
1151 }; 1161 };
1152 1162
1153 /** @typedef {!{type: SDK.NetworkRequest.WebSocketFrameType, time: number, text: string, opCode: number, mask: boolean}} */ 1163 /** @typedef {!{type: SDK.NetworkRequest.WebSocketFrameType, time: number, text: string, opCode: number, mask: boolean}} */
1154 SDK.NetworkRequest.WebSocketFrame; 1164 SDK.NetworkRequest.WebSocketFrame;
1155 1165
1156 /** @typedef {!{time: number, eventName: string, eventId: string, data: string}} */ 1166 /** @typedef {!{time: number, eventName: string, eventId: string, data: string}} */
1157 SDK.NetworkRequest.EventSourceMessage; 1167 SDK.NetworkRequest.EventSourceMessage;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698