third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js - Issue 2859053007: [DevTools] prepare frontend for new async stacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

Issue 2859053007: [DevTools] prepare frontend for new async stacks (Closed)

Patch Set: added rebased test Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/async-call-stack-async-function-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

index f827cb0c68dda5a2179eca85360e266091d40ee4..def9c701a858985bf84ad9980c8cdfc7380c2dc7 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

@@ -96,10 +96,8 @@ Sources.CallStackSidebarPane = class extends UI.SimpleView {

var isAwait = asyncStackTrace.description === 'async function';

if (isAwait && peviousStackTrace.length && asyncStackTrace.callFrames.length) {

var lastPreviousFrame = peviousStackTrace[peviousStackTrace.length - 1];

- var topFrame = asyncStackTrace.callFrames[0];

var lastPreviousFrameName = UI.beautifyFunctionName(lastPreviousFrame.functionName);

- var topFrameName = UI.beautifyFunctionName(topFrame.functionName);

- title = topFrameName + ' awaits ' + lastPreviousFrameName;

+ title = UI.asyncStackTraceLabel('await in ' + lastPreviousFrameName);

} else {

title = UI.asyncStackTraceLabel(asyncStackTrace.description);

}