Display the error code when certificates fail to add

Display the error code when certificates fail to add

We really want to make error strings, but this is a start.

BUG=43906
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52499

[wtc, 2010-06-25 00:09:04]

This looks good, but I suggest two changes for consistency
with our current network error page.

1. Display the absolute value of the error code, e.g.,
207 instead of -207.

2. Also display the stringized error code, e.g.,
"net::ERR_INVALID_CERT".

http://codereview.chromium.org/2859026/diff/1/2
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/2859026/diff/1/2#newcode3098
chrome/app/generated_resources.grd:3098: The server returned an invalid client
certificate. Error code: <ph name="ERRORCODE">$1<ex>-207</ex></ph>
Let's imitate the IDS_ERRORPAGES_DETAILS_TEMPLATE string,
which has both the error code and the stringized version
of the error code.  Also note that we pass the absolute
value of the error code so that we display a positive number.

See src/chrome/renderer/localized_error.cc, search for
"IDS_ERRORPAGES_DETAILS_TEMPLATE".

[David Benjamin, 2010-06-25 01:09:22]

Displaying the stringified error name (Fancy. I didn't know we had such a
thing.)

Could things be confusing with some of the errors being in the right range for
HTTP status codes without actually being them, or are these standard SSL error
codes?

http://codereview.chromium.org/2859026/diff/1/2
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/2859026/diff/1/2#newcode3098
chrome/app/generated_resources.grd:3098: The server returned an invalid client
certificate. Error code: <ph name="ERRORCODE">$1<ex>-207</ex></ph>
On 2010/06/25 00:09:04, wtc wrote:
> Let's imitate the IDS_ERRORPAGES_DETAILS_TEMPLATE string,
> which has both the error code and the stringized version
> of the error code.  Also note that we pass the absolute
> value of the error code so that we display a positive number.
> 
> See src/chrome/renderer/localized_error.cc, search for
> "IDS_ERRORPAGES_DETAILS_TEMPLATE".

Done.

[wtc, 2010-06-25 01:22:51]

LGTM.

These are not standard SSL error codes.  These are the error codes used
by our network stack.  The stringized error codes make it clear that these
are not HTTP status codes.