Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceBase.cpp

Issue 2858963002: Replace ASSERT with DCHECK in core/ (Closed)
Patch Set: WorkerBackingThread Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceBase.cpp
diff --git a/third_party/WebKit/Source/core/timing/PerformanceBase.cpp b/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
index 1b09ef6d3c41973ea349888fdfcc4e1c71b250ae..4cef3f693921cb497c8a1e110e02c46908d496c2 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
+++ b/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
@@ -367,14 +367,14 @@ void PerformanceBase::AddResourceTiming(const ResourceTimingInfo& info) {
if (!allow_redirect_details) {
ResourceLoadTiming* final_timing = final_response.GetResourceLoadTiming();
- ASSERT(final_timing);
+ DCHECK(final_timing);
if (final_timing)
start_time = final_timing->RequestTime();
}
ResourceLoadTiming* last_redirect_timing =
redirect_chain.back().GetResourceLoadTiming();
- ASSERT(last_redirect_timing);
+ DCHECK(last_redirect_timing);
double last_redirect_end_time = last_redirect_timing->ReceiveHeadersEnd();
PerformanceEntry* entry = PerformanceResourceTiming::Create(
@@ -488,7 +488,7 @@ void PerformanceBase::RegisterPerformanceObserver(
void PerformanceBase::UnregisterPerformanceObserver(
PerformanceObserver& old_observer) {
- ASSERT(IsMainThread());
+ DCHECK(IsMainThread());
// Deliver any pending observations on this observer before unregistering.
if (active_observers_.Contains(&old_observer) &&
!old_observer.ShouldBeSuspended()) {
@@ -535,7 +535,7 @@ void PerformanceBase::ActivateObserver(PerformanceObserver& observer) {
}
void PerformanceBase::ResumeSuspendedObservers() {
- ASSERT(IsMainThread());
+ DCHECK(IsMainThread());
if (suspended_observers_.IsEmpty())
return;
@@ -550,7 +550,7 @@ void PerformanceBase::ResumeSuspendedObservers() {
}
void PerformanceBase::DeliverObservationsTimerFired(TimerBase*) {
- ASSERT(IsMainThread());
+ DCHECK(IsMainThread());
PerformanceObservers observers;
active_observers_.Swap(observers);
for (const auto& observer : observers) {

Powered by Google App Engine
This is Rietveld 408576698