third_party/WebKit/Source/core/streams/ReadableStreamOperationsTest.cpp - Issue 2858963002: Replace ASSERT with DCHECK in core/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/streams/ReadableStreamOperationsTest.cpp

Issue 2858963002: Replace ASSERT with DCHECK in core/ (Closed)

Patch Set: WorkerBackingThread Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/streams/ReadableStreamOperations.cpp ('k') | third_party/WebKit/Source/core/streams/UnderlyingSourceBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/streams/ReadableStreamOperationsTest.cpp

diff --git a/third_party/WebKit/Source/core/streams/ReadableStreamOperationsTest.cpp b/third_party/WebKit/Source/core/streams/ReadableStreamOperationsTest.cpp

index d90424efda2e0371cd4bfd198a57c2001fdbf6ac..82d2c2136c55407b5d1979240a5c5ce9697bad84 100644

--- a/third_party/WebKit/Source/core/streams/ReadableStreamOperationsTest.cpp

+++ b/third_party/WebKit/Source/core/streams/ReadableStreamOperationsTest.cpp

@@ -48,7 +48,7 @@ class Iteration final : public GarbageCollectedFinalized<Iteration> {

Iteration() : is_set_(false), is_done_(false), is_valid_(true) {}

void Set(ScriptValue v) {

- ASSERT(!v.IsEmpty());

+ DCHECK(!v.IsEmpty());

is_set_ = true;

v8::TryCatch block(v.GetScriptState()->GetIsolate());

v8::Local<v8::Value> value;