Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: third_party/WebKit/Source/core/page/Page.cpp

Issue 2858963002: Replace ASSERT with DCHECK in core/ (Closed)
Patch Set: WorkerBackingThread Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/Page.cpp
diff --git a/third_party/WebKit/Source/core/page/Page.cpp b/third_party/WebKit/Source/core/page/Page.cpp
index 941a30cba6fd96f8a8ec73ec3d1db13876015b52..6dc4b2180bc29db3eaaf4c604531a8cad016befb 100644
--- a/third_party/WebKit/Source/core/page/Page.cpp
+++ b/third_party/WebKit/Source/core/page/Page.cpp
@@ -129,15 +129,15 @@ Page::Page(PageClients& page_clients)
visibility_state_(kPageVisibilityStateVisible),
is_cursor_visible_(true),
subframe_count_(0) {
- ASSERT(editor_client_);
+ DCHECK(editor_client_);
- ASSERT(!AllPages().Contains(this));
+ DCHECK(!AllPages().Contains(this));
AllPages().insert(this);
}
Page::~Page() {
// willBeDestroyed() must be called before Page destruction.
- ASSERT(!main_frame_);
+ DCHECK(!main_frame_);
}
void Page::CloseSoon() {
@@ -654,7 +654,7 @@ void Page::WillBeDestroyed() {
if (main_frame->IsAttached())
main_frame->Detach(FrameDetachType::kRemove);
- ASSERT(AllPages().Contains(this));
+ DCHECK(AllPages().Contains(this));
AllPages().erase(this);
OrdinaryPages().erase(this);
« no previous file with comments | « third_party/WebKit/Source/core/page/CreateWindow.cpp ('k') | third_party/WebKit/Source/core/page/PagePopupController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698