third_party/WebKit/Source/core/page/ChromeClient.cpp - Issue 2858963002: Replace ASSERT with DCHECK in core/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/ChromeClient.cpp

Issue 2858963002: Replace ASSERT with DCHECK in core/ (Closed)

Patch Set: WorkerBackingThread Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp ('k') | third_party/WebKit/Source/core/page/ContextMenuController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/ChromeClient.cpp

diff --git a/third_party/WebKit/Source/core/page/ChromeClient.cpp b/third_party/WebKit/Source/core/page/ChromeClient.cpp

index a7c4ea868efbf805f6c00a50f6c8e5cf9fadac22..de6af36341fd010ea6f0d74ac0e88986a347b4c6 100644

--- a/third_party/WebKit/Source/core/page/ChromeClient.cpp

+++ b/third_party/WebKit/Source/core/page/ChromeClient.cpp

@@ -112,7 +112,7 @@ static bool OpenJavaScriptDialog(LocalFrame* frame,

bool ChromeClient::OpenBeforeUnloadConfirmPanel(const String& message,

LocalFrame* frame,

bool is_reload) {

- ASSERT(frame);

+ DCHECK(frame);

return OpenJavaScriptDialog(

frame, message, ChromeClient::kHTMLDialog, [this, frame, is_reload]() {

return OpenBeforeUnloadConfirmPanelDelegate(frame, is_reload);

@@ -121,7 +121,7 @@ bool ChromeClient::OpenBeforeUnloadConfirmPanel(const String& message,

bool ChromeClient::OpenJavaScriptAlert(LocalFrame* frame,

const String& message) {

- ASSERT(frame);

+ DCHECK(frame);

if (!CanOpenModalIfDuringPageDismissal(frame->Tree().Top(),

ChromeClient::kAlertDialog, message))

return false;

@@ -133,7 +133,7 @@ bool ChromeClient::OpenJavaScriptAlert(LocalFrame* frame,

bool ChromeClient::OpenJavaScriptConfirm(LocalFrame* frame,

const String& message) {

- ASSERT(frame);

+ DCHECK(frame);

if (!CanOpenModalIfDuringPageDismissal(frame->Tree().Top(),

ChromeClient::kConfirmDialog, message))

return false;

@@ -147,7 +147,7 @@ bool ChromeClient::OpenJavaScriptPrompt(LocalFrame* frame,

const String& prompt,

const String& default_value,

String& result) {

- ASSERT(frame);

+ DCHECK(frame);

if (!CanOpenModalIfDuringPageDismissal(frame->Tree().Top(),

ChromeClient::kPromptDialog, prompt))

return false;