Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp

Issue 2858963002: Replace ASSERT with DCHECK in core/ (Closed)
Patch Set: WorkerBackingThread Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp b/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
index bca637c97c2b0d2c9457f2a4a89f3c6c74519f58..5577eec78d21394b0f7de24db172c752724dff10 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
@@ -501,7 +501,7 @@ std::unique_ptr<TracedValue>
InspectorStyleRecalcInvalidationTrackingEvent::Data(
Node* node,
const StyleChangeReasonForTracing& reason) {
- ASSERT(node);
+ DCHECK(node);
std::unique_ptr<TracedValue> value = TracedValue::Create();
value->SetString("frame", ToHexString(node->GetDocument().GetFrame()));
@@ -611,7 +611,7 @@ const char kScrollbarChanged[] = "Scrollbar changed";
std::unique_ptr<TracedValue> InspectorLayoutInvalidationTrackingEvent::Data(
const LayoutObject* layout_object,
LayoutInvalidationReasonForTracing reason) {
- ASSERT(layout_object);
+ DCHECK(layout_object);
std::unique_ptr<TracedValue> value = TracedValue::Create();
value->SetString("frame", ToHexString(layout_object->GetFrame()));
SetGeneratingNodeInfo(value.get(), layout_object, "nodeId", "nodeName");
@@ -623,7 +623,7 @@ std::unique_ptr<TracedValue> InspectorLayoutInvalidationTrackingEvent::Data(
std::unique_ptr<TracedValue> InspectorPaintInvalidationTrackingEvent::Data(
const LayoutObject* layout_object,
const LayoutObject& paint_container) {
- ASSERT(layout_object);
+ DCHECK(layout_object);
std::unique_ptr<TracedValue> value = TracedValue::Create();
value->SetString("frame", ToHexString(layout_object->GetFrame()));
SetGeneratingNodeInfo(value.get(), &paint_container, "paintId");

Powered by Google App Engine
This is Rietveld 408576698