third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp - Issue 2858963002: Replace ASSERT with DCHECK in core/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

Issue 2858963002: Replace ASSERT with DCHECK in core/ (Closed)

Patch Set: WorkerBackingThread Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

index 26709a03210fbdfec308d89279ffa3e8b51afac4..8c087615c7a6679189be068f61c8fab55391dc98 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

@@ -556,7 +556,7 @@ void InspectorDOMDebuggerAgent::BreakProgramOnDOMEvent(Node* target,

// Find breakpoint owner node.

if (!insertion)

breakpoint_owner = InspectorDOMAgent::InnerParentNode(target);

- ASSERT(breakpoint_owner);

+ DCHECK(breakpoint_owner);

while (!(dom_breakpoints_.at(breakpoint_owner) & (1 << breakpoint_type))) {

Node* parent_node = InspectorDOMAgent::InnerParentNode(breakpoint_owner);

if (!parent_node)

@@ -569,7 +569,7 @@ void InspectorDOMDebuggerAgent::BreakProgramOnDOMEvent(Node* target,

}

int breakpoint_owner_node_id = dom_agent_->BoundNodeId(breakpoint_owner);

- ASSERT(breakpoint_owner_node_id);

+ DCHECK(breakpoint_owner_node_id);

description->setInteger("nodeId", breakpoint_owner_node_id);

description->setString("type", DomTypeName(breakpoint_type));

String json = description->serialize();