Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: third_party/WebKit/Source/core/input/TouchEventManager.cpp

Issue 2858963002: Replace ASSERT with DCHECK in core/ (Closed)
Patch Set: WorkerBackingThread Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/TouchEventManager.cpp
diff --git a/third_party/WebKit/Source/core/input/TouchEventManager.cpp b/third_party/WebKit/Source/core/input/TouchEventManager.cpp
index e101550859301d2968755b430569dfd744e398aa..fa285afc85cc5c0f3566b42f9a390ae597d7b147 100644
--- a/third_party/WebKit/Source/core/input/TouchEventManager.cpp
+++ b/third_party/WebKit/Source/core/input/TouchEventManager.cpp
@@ -354,7 +354,7 @@ void TouchEventManager::UpdateTargetAndRegionMapsForTouchStarts(
// in the active sequence. This must be a single document to
// ensure we don't leak Nodes between documents.
touch_sequence_document_ = &(touch_info.touch_node->GetDocument());
- ASSERT(touch_sequence_document_->GetFrame()->View());
+ DCHECK(touch_sequence_document_->GetFrame()->View());
}
// Ideally we'd ASSERT(!m_targetForTouchID.contains(point.id())
@@ -431,7 +431,7 @@ void TouchEventManager::SetAllPropertiesOfTouchInfos(
touch_node = touch_sequence_document_;
target_frame = touch_sequence_document_->GetFrame();
}
- ASSERT(target_frame);
+ DCHECK(target_frame);
// pagePoint should always be in the target element's document coordinates.
FloatPoint page_point =
@@ -472,7 +472,7 @@ bool TouchEventManager::ReHitTestTouchPointsIfNeeded(
touch_sequence_document_.Clear();
}
- ASSERT(frame_->View());
+ DCHECK(frame_->View());
if (touch_sequence_document_ &&
(!touch_sequence_document_->GetFrame() ||
!touch_sequence_document_->GetFrame()->View())) {
« no previous file with comments | « third_party/WebKit/Source/core/input/EventHandler.cpp ('k') | third_party/WebKit/Source/core/inspector/DOMEditor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698