third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp - Issue 2858963002: Replace ASSERT with DCHECK in core/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp

Issue 2858963002: Replace ASSERT with DCHECK in core/ (Closed)

Patch Set: WorkerBackingThread Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/canvas/CanvasFontCache.cpp ('k') | third_party/WebKit/Source/core/input/EventHandler.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp

diff --git a/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp b/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp

index 482ec20ca7b35e03679c10a41d6b6972a8f04408..8c6f54013b3f445c0d0cc2fa5c83a3f7e57053df 100644

--- a/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp

+++ b/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp

@@ -191,7 +191,7 @@ ImageBitmapFactories& ImageBitmapFactories::From(EventTarget& event_target) {

if (LocalDOMWindow* window = event_target.ToLocalDOMWindow())

return FromInternal(*window);

- ASSERT(event_target.GetExecutionContext()->IsWorkerGlobalScope());

+ DCHECK(event_target.GetExecutionContext()->IsWorkerGlobalScope());

return ImageBitmapFactories::FromInternal(

*ToWorkerGlobalScope(event_target.GetExecutionContext()));

}

@@ -212,7 +212,7 @@ void ImageBitmapFactories::AddLoader(ImageBitmapLoader* loader) {

}

void ImageBitmapFactories::DidFinishLoading(ImageBitmapLoader* loader) {

- ASSERT(pending_loaders_.Contains(loader));

+ DCHECK(pending_loaders_.Contains(loader));

pending_loaders_.erase(loader);

}

@@ -277,7 +277,7 @@ void ImageBitmapFactories::ImageBitmapLoader::DecodeImageOnDecoderThread(

DOMArrayBuffer* array_buffer,

const String& premultiply_alpha_option,

const String& color_space_conversion_option) {

- ASSERT(!IsMainThread());

+ DCHECK(!IsMainThread());

ImageDecoder::AlphaOption alpha_op = ImageDecoder::kAlphaPremultiplied;

if (premultiply_alpha_option == "none")