third_party/WebKit/Source/core/frame/VisualViewport.cpp - Issue 2858963002: Replace ASSERT with DCHECK in core/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/VisualViewport.cpp

Issue 2858963002: Replace ASSERT with DCHECK in core/ (Closed)

Patch Set: WorkerBackingThread Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/VisualViewport.cpp

diff --git a/third_party/WebKit/Source/core/frame/VisualViewport.cpp b/third_party/WebKit/Source/core/frame/VisualViewport.cpp

index 32be070c8763265800bb3e769c9e5bf8dd38bd8d..615977dae8bbed12fabeac6b84b08b47a602768b 100644

--- a/third_party/WebKit/Source/core/frame/VisualViewport.cpp

+++ b/third_party/WebKit/Source/core/frame/VisualViewport.cpp

@@ -442,7 +442,7 @@ void VisualViewport::SetupScrollbar(WebScrollbar::Orientation orientation) {

if (!web_scrollbar_layer) {

ScrollingCoordinator* coordinator = GetPage().GetScrollingCoordinator();

- ASSERT(coordinator);

+ DCHECK(coordinator);

ScrollbarOrientation webcore_orientation =

is_horizontal ? kHorizontalScrollbar : kVerticalScrollbar;

web_scrollbar_layer = coordinator->CreateSolidColorScrollbarLayer(