Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

Issue 2858963002: Replace ASSERT with DCHECK in core/ (Closed)
Patch Set: WorkerBackingThread Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
diff --git a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
index 80de18ae8ea834729597b1832bc49bf8d8f763af..9007394cea928f54107e772671fd1fdf9d5ceaae 100644
--- a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
+++ b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
@@ -295,7 +295,7 @@ void LocalDOMWindow::ClearDocument() {
if (!document_)
return;
- ASSERT(!document_->IsActive());
+ DCHECK(!document_->IsActive());
// FIXME: This should be part of SuspendableObject shutdown
ClearEventQueue();
@@ -464,7 +464,7 @@ void LocalDOMWindow::StatePopped(
LocalDOMWindow::~LocalDOMWindow() {
// Cleared when detaching document.
- ASSERT(!event_queue_);
+ DCHECK(!event_queue_);
}
void LocalDOMWindow::Dispose() {
@@ -529,7 +529,7 @@ void LocalDOMWindow::Reset() {
}
void LocalDOMWindow::SendOrientationChangeEvent() {
- ASSERT(RuntimeEnabledFeatures::orientationEventEnabled());
+ DCHECK(RuntimeEnabledFeatures::orientationEventEnabled());
DCHECK(GetFrame()->IsLocalRoot());
// Before dispatching the event, build a list of all frames in the page
@@ -552,7 +552,7 @@ void LocalDOMWindow::SendOrientationChangeEvent() {
}
int LocalDOMWindow::orientation() const {
- ASSERT(RuntimeEnabledFeatures::orientationEventEnabled());
+ DCHECK(RuntimeEnabledFeatures::orientationEventEnabled());
if (!GetFrame() || !GetFrame()->GetPage())
return 0;
@@ -1120,7 +1120,7 @@ void LocalDOMWindow::setName(const AtomicString& name) {
return;
GetFrame()->Tree().SetName(name);
- ASSERT(GetFrame()->Loader().Client());
+ DCHECK(GetFrame()->Loader().Client());
GetFrame()->Loader().Client()->DidChangeName(name);
}
@@ -1167,7 +1167,7 @@ StyleMedia* LocalDOMWindow::styleMedia() const {
CSSStyleDeclaration* LocalDOMWindow::getComputedStyle(
Element* elt,
const String& pseudo_elt) const {
- ASSERT(elt);
+ DCHECK(elt);
return CSSComputedStyleDeclaration::Create(elt, false, pseudo_elt);
}
« no previous file with comments | « third_party/WebKit/Source/core/frame/LayoutSubtreeRootList.cpp ('k') | third_party/WebKit/Source/core/frame/LocalFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698