third_party/WebKit/Source/core/css/SelectorFilter.cpp - Issue 2858963002: Replace ASSERT with DCHECK in core/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/SelectorFilter.cpp

Issue 2858963002: Replace ASSERT with DCHECK in core/ (Closed)

Patch Set: WorkerBackingThread Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/SelectorFilter.cpp

diff --git a/third_party/WebKit/Source/core/css/SelectorFilter.cpp b/third_party/WebKit/Source/core/css/SelectorFilter.cpp

index cd78a450228da1fff096435f0844061232e06759..4b50414ec24b5b99389f597a14d261f93133d5d4 100644

--- a/third_party/WebKit/Source/core/css/SelectorFilter.cpp

+++ b/third_party/WebKit/Source/core/css/SelectorFilter.cpp

@@ -87,7 +87,9 @@ void SelectorFilter::PopParentStackFrame() {

ancestor_identifier_filter_->Remove(parent_frame.identifier_hashes[i]);

parent_stack_.pop_back();

if (parent_stack_.IsEmpty()) {

- ASSERT(ancestor_identifier_filter_->LikelyEmpty());

+#if DCHECK_IS_ON()

+ DCHECK(ancestor_identifier_filter_->LikelyEmpty());

+#endif

ancestor_identifier_filter_.reset();

}